-
Notifications
You must be signed in to change notification settings - Fork 2k
[None][feat] add Hopper FP8 context MLA #7107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
acef6e8
test pass
zhou-yuxin 27ed25a
pre-commit format
zhou-yuxin cdd456f
test pass
zhou-yuxin 1fe8273
pre-commit format
zhou-yuxin 4338e08
[None][chore] Update namelist in blossom-ci (#7015)
karljang d271157
[None][ci] move unittests to sub-directories (#6635)
Funatiq 89747a8
[None][infra] Waive failed tests on main branch 8/20 (#7092)
EmmaQiaoCh 8d445a4
[None][fix] Fix W4A8 MoE kernel issue (#7072)
yuhyao d36ba89
[TRTLLM-7348] [feat] Enable Cross-Attention to use XQA kernels for Wh…
DomBrown 5920e6e
[None][chore] Only check the bindings lib for current build (#7026)
liji-nv 54bc8fd
[None][ci] move some tests of b200 to post merge (#7093)
QiJune 29aee2a
[https://nvbugs/5457489][fix] unwaive some tests (#6991)
byshiue 890dda6
[TRTLLM-6771][feat] Support MMMU for multimodal models (#6828)
yechank-nvidia ab3153c
[None][fix] Fix llama4 multimodal by skipping request validation (#6957)
chang-l 1b3709e
[None][infra] Upgrade UCX to v1.19.x and NIXL to 0.5.0 (#7024)
BatshevaBlack d84e1c7
[None][fix] update accelerate dependency to 1.7+ for AutoDeploy (#7077)
Fridah-nv c923ba7
[None][fix] Fix const modifier inconsistency in log function declarat…
Fan-Yunfan 8233dda
[None][chore] waive failed cases on H100 (#7084)
xinhe-nv 176f367
[fix]: use safeInitRowMax instead of fp32_lowest to avoid NaN (#7087)
lowsfer cc35ba2
[https://nvbugs/5443039][fix] Fix AutoDeploy pattern matcher for torc…
Fridah-nv 9631242
[https://nvbugs/5437405][fix] qwen3 235b eagle3 ci (#7000)
byshiue 810beb2
[None][doc] Update gpt-oss deployment guide to latest release image (…
farshadghodsian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
test pass
Signed-off-by: Yuxin <yuxinz@nvidia.com>
- Loading branch information
commit acef6e808a7bd795eb919dbd2ed71b9dfc2108d8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
New externs for 192x128 S_q_k_v (and BF16 output) look consistent; please verify out-of-line definitions exist.
Signatures follow existing conventions and appear correct. To avoid ODR/link issues, confirm these have exactly one non-extern definition and that parameter names match between declaration and definition (per guidelines).
Run this script from repo root to verify definitions and parameter-name consistency:
Optionally, if these are SM90-only implementations, consider guarding the declarations/uses with the same compile-time condition used for other SM90-only symbols for consistency.
🏁 Script executed:
Length of output: 669
🏁 Script executed:
Length of output: 3201
🏁 Script executed:
Length of output: 12014
Missing out-of-line definitions for new SM90 externs
Our scan of all
.cppand.cufiles did not locate non-extern definitions for the two new functions declared incpp/tensorrt_llm/kernels/contextFusedMultiHeadAttention/cubin/fmha_cubin.hat lines 263–264:run_fmha_v2_flash_attention_e4m3_64_128_S_q_k_v_192x128_tma_ws_sm90run_fmha_v2_flash_attention_e4m3_64_128_S_q_k_v_192x128_output_bf16_tma_ws_sm90Without matching definitions, the build will fail at link time. Please add implementations—e.g. in the existing
fmha_cubin.cu(or a new.cpp/.cu)—ensuring:params,launch_params,stream).– File to update:
•
cpp/tensorrt_llm/kernels/contextFusedMultiHeadAttention/cubin/fmha_cubin.h(lines 263–264)• Corresponding
.cuor.cppwhere definitions belong.🤖 Prompt for AI Agents