Skip to content

[None] [feat] Use numa to bind CPU #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaiyux merged 2 commits into from
Aug 28, 2025
Merged

[None] [feat] Use numa to bind CPU #7304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a71240
Use numa to bind CPU
kaiyux Aug 27, 2025
8d60cc7
Make numa bind optional
kaiyux Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions examples/disaggregated/slurm/benchmark/disaggr_torch.slurm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,11 @@ echo "ntasks_per_node: ${ntasks_per_node}"
echo "==========================================="


ctx_max_seq_len=$((isl + 1))
gen_max_seq_len=$((isl + osl))
nsys_on=""
# nsys_on=${full_logdir} # Uncomment this line to enable Nsys profiling
numa_bind=true # Only allocate memory from nodes, this only works on GB200
ctx_max_seq_len=$((isl + 10))
gen_max_seq_len=$((isl + osl + 10))
ctx_gpu_frac=${ctx_gpu_memory_fraction}
cache_transceiver_max_num_tokens=8448

Expand Down Expand Up @@ -120,9 +123,6 @@ if [ -z "${TRT_LLM_GIT_COMMIT:-}" ]; then
echo "TRT_LLM_GIT_COMMIT: ${TRT_LLM_GIT_COMMIT}"
fi

nsys_on=""
# nsys_on=${full_logdir} # Uncomment this line to enable Nsys profiling

# start the container
srun -l --container-image=${container_image} \
--container-name=${container_name} \
Expand Down Expand Up @@ -193,7 +193,7 @@ for i in $(seq 0 $((num_gen_servers - 1))); do
--container-name=${container_name} \
--container-mounts=${mounts} \
--mpi=pmix \
bash ${workdir}/start_worker.sh "GEN" ${i} ${model_dir} "8336" ${benchmark_mode} ${concurrency} ${enable_pdl} ${full_logdir} ${nsys_on} \
bash ${workdir}/start_worker.sh "GEN" ${i} ${model_dir} "8336" ${benchmark_mode} ${concurrency} ${enable_pdl} ${numa_bind} ${full_logdir} ${nsys_on} \
&> ${full_logdir}/output_gen_${i}.log &
done

Expand All @@ -206,7 +206,7 @@ for i in $(seq 0 $((num_ctx_servers - 1))); do
--container-name=${container_name} \
--container-mounts=${mounts} \
--mpi=pmix \
bash ${workdir}/start_worker.sh "CTX" ${i} ${model_dir} "8336" ${benchmark_mode} ${concurrency} ${enable_pdl} ${full_logdir} ${nsys_on} \
bash ${workdir}/start_worker.sh "CTX" ${i} ${model_dir} "8336" ${benchmark_mode} ${concurrency} ${enable_pdl} ${numa_bind} ${full_logdir} ${nsys_on} \
&> ${full_logdir}/output_ctx_${i}.log &
done

Expand Down
17 changes: 13 additions & 4 deletions examples/disaggregated/slurm/benchmark/start_worker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ port=$4
benchmark_mode=$5
concurrency=$6
enable_pdl=$7
work_dir=$8
nsys_folder=${9:-}
numa_bind=$8
work_dir=$9
nsys_folder=${10:-}

unset UCX_TLS
echo "concurrency: ${concurrency}, enable_pdl: ${enable_pdl}, work_dir: ${work_dir}"
Expand All @@ -23,6 +24,14 @@ if [ "${enable_pdl}" = "true" ]; then
export TRTLLM_ENABLE_PDL=1
fi

if [ "${numa_bind}" = "true" ]; then
numa_bind_cmd="numactl -m 0,1"
echo "numactl -m 0,1 - Only allocate memory from nodes on GB200"
else
numa_bind_cmd=""
echo "Not binding memory. If on GB200, use \"numactl -m 0,1\" to only allocate memory from nodes."
fi

if [ "${benchmark_mode}" = "gen_only" ]; then
export TRTLLM_DISABLE_KV_CACHE_TRANSFER_OVERLAP=1
export TLLM_BENCHMARK_REQ_QUEUES_SIZE=${concurrency}
Expand Down Expand Up @@ -50,7 +59,7 @@ fi
#check if nsys_folder is provided
if [ -z "${nsys_folder:-}" ]; then
echo "nsys is not enabled, start normal flow"
trtllm-llmapi-launch trtllm-serve ${model_path} --host $(hostname) --port ${port} --extra_llm_api_options ${config_file}
trtllm-llmapi-launch ${numa_bind_cmd} trtllm-serve ${model_path} --host $(hostname) --port ${port} --extra_llm_api_options ${config_file}
else
nsys_prefix=""
nsys_file=${nsys_folder}/nsys_worker_proc_${instance_id}_${SLURM_PROCID}
Expand All @@ -63,7 +72,7 @@ else
elif [ "${role}" = "CTX" ]; then
echo "nsys is not enabled on ctx_gpus"
fi
trtllm-llmapi-launch ${nsys_prefix} \
trtllm-llmapi-launch ${numa_bind_cmd} ${nsys_prefix} \
trtllm-serve ${model_path} \
--host $(hostname) --port ${port} \
--extra_llm_api_options ${config_file}
Expand Down
Loading