[None][ci] - Avoid the Git-metadata error and skip VCS in build-info collection #7527
Conversation
📝 WalkthroughWalkthroughUpdates Jenkins pipelines to load a different shared library branch, add post-checkout cleanup (.git removal), adjust artifact packaging and upload spec, and make a cosmetic indentation change in a Docker install script. No public API changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant J as Jenkins Pipeline
participant SCM as Git Repo
participant FS as Workspace
participant PKG as Tar Packager
participant RT as Artifactory
J->>SCM: Checkout LLM sources
J->>FS: Remove .git under ${LLM_ROOT}\n(List pwd, ls -alh)
J->>PKG: Remove existing tar (if any)
J->>PKG: Create fresh tar from workspace
J->>RT: rtUpload(spec with buildInfo.skip=true)
RT-->>J: Upload result
note over J,FS: New/changed: .git cleanup, explicit tar pre-removal, upload spec via variable
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
jenkins/BuildDockerImage.groovy (1)
1-1: Pin the shared library to an immutable refBranch
trtllm-jenkins-shared-lib@yanchaol-uploadcan drift. Prefer a tag or commit SHA to make builds reproducible and safer.jenkins/L0_MergeRequest.groovy (1)
1-1: Pin the shared library to an immutable refSame note: use a tag/commit SHA instead of
yanchaol-uploadto avoid unexpected behavior on branch moves.jenkins/L0_Test.groovy (3)
1-1: Pin the shared library to an immutable refUse a tag or commit SHA for
trtllm-jenkins-shared-librather than the mutableyanchaol-uploadbranch.
1776-1777: Removing .git after checkout — good; persist the commit for traceabilityDeleting
.githelps avoid VCS introspection issues. Recommend writing the commit SHA to a file before removal so artifacts/tests can still reference it.Apply this diff near the checkout, before removing
.git:trtllm_utils.checkoutSource(LLM_REPO, env.gitlabCommit, "tensorrt_llm", true, true) +sh "cd tensorrt_llm && printf '%s' '${env.gitlabCommit}' > COMMIT_SHA || true" sh "cd tensorrt_llm && pwd && ls -alh && rm -rf .git"
2285-2285: Mirror the commit persistence here as wellBefore
rm -rf .git, dropCOMMIT_SHAfor later debugging.trtllm_utils.checkoutSource(LLM_REPO, env.gitlabCommit, LLM_ROOT, true, true) - sh "cd ${LLM_ROOT} && pwd && ls -alh && rm -rf .git" + sh "cd ${LLM_ROOT} && printf '%s' '${env.gitlabCommit}' > COMMIT_SHA || true && pwd && ls -alh && rm -rf .git"jenkins/Build.groovy (3)
1-1: Pin the shared library to an immutable refReplace
yanchaol-uploadwith a tag or commit SHA for deterministic builds.
497-498: Also capture SHA before removing.gitin wheel buildMirror the commit persistence here for consistency.
trtllm_utils.checkoutSource(LLM_REPO, env.gitlabCommit, LLM_ROOT, true, true) - sh "cd ${LLM_ROOT} && pwd && ls -alh && rm -rf .git" + sh "cd ${LLM_ROOT} && printf '%s' '${env.gitlabCommit}' > COMMIT_SHA || true && pwd && ls -alh && rm -rf .git"
411-412: Captureenv.gitlabCommitbefore cleaning up.gitThe L0_MergeRequest pipeline already records the commit SHA into
env.gitlabCommitviagit rev-parse HEAD. In Build.groovy, persist this value to aCOMMIT_SHAfile before removing the.gitdirectory:trtllm_utils.checkoutSource(LLM_REPO, env.gitlabCommit, LLM_ROOT, true, true) - sh "cd ${LLM_ROOT} && pwd && ls -alh && rm -rf .git" + sh "cd ${LLM_ROOT} && printf '%s' \"${env.gitlabCommit}\" > COMMIT_SHA && pwd && ls -alh && rm -rf .git"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
docker/common/install_tensorrt.sh(1 hunks)jenkins/Build.groovy(5 hunks)jenkins/BuildDockerImage.groovy(1 hunks)jenkins/L0_MergeRequest.groovy(1 hunks)jenkins/L0_Test.groovy(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Filenames compiled into a target must be case-insensitively unique
Files:
jenkins/BuildDockerImage.groovyjenkins/L0_MergeRequest.groovydocker/common/install_tensorrt.shjenkins/Build.groovyjenkins/L0_Test.groovy
🧠 Learnings (4)
📚 Learning: 2025-08-18T09:08:07.687Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#6984
File: cpp/tensorrt_llm/CMakeLists.txt:297-299
Timestamp: 2025-08-18T09:08:07.687Z
Learning: In the TensorRT-LLM project, artifacts are manually copied rather than installed via `cmake --install`, so INSTALL_RPATH properties are not needed - only BUILD_RPATH affects the final artifacts.
Applied to files:
jenkins/Build.groovyjenkins/L0_Test.groovy
📚 Learning: 2025-08-11T20:09:24.389Z
Learnt from: achartier
PR: NVIDIA/TensorRT-LLM#6763
File: tests/integration/defs/triton_server/conftest.py:16-22
Timestamp: 2025-08-11T20:09:24.389Z
Learning: In the TensorRT-LLM test infrastructure, the team prefers simple, direct solutions (like hard-coding directory traversal counts) over more complex but robust approaches when dealing with stable directory structures. They accept the maintenance cost of updating tests if the layout changes.
Applied to files:
jenkins/L0_Test.groovy
📚 Learning: 2025-08-06T13:58:07.506Z
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
Applied to files:
jenkins/L0_Test.groovy
📚 Learning: 2025-08-01T15:14:45.673Z
Learnt from: yibinl-nvidia
PR: NVIDIA/TensorRT-LLM#6506
File: examples/models/core/mixtral/requirements.txt:3-3
Timestamp: 2025-08-01T15:14:45.673Z
Learning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.
Applied to files:
jenkins/L0_Test.groovy
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
docker/common/install_tensorrt.sh (1)
69-69: Whitespace-only change — OKIndentation tweak has no functional impact; package pinning and trailing backslashes remain correct.
jenkins/Build.groovy (2)
476-477: Pre-removing existing tarball is a safe cleanupAvoids stale packaging artifacts; looks good.
324-336: All rtUpload specs now skip buildInfo as intended
The solertUploadcall injenkins/Build.groovyincludes"buildInfo": {"skip": true}, preventing any Artifactory Git-metadata lookups.
|
/bot run |
|
PR_Github #17678 [ run ] triggered by Bot |
|
PR_Github #17678 [ run ] completed with state |
chzblych
force-pushed
the
yanchaol-upload
branch
from
32a521b to
3afd12a
Compare
|
/bot run |
|
PR_Github #17991 [ run ] triggered by Bot |
|
PR_Github #17991 [ run ] completed with state |
chzblych
force-pushed
the
yanchaol-upload
branch
from
3afd12a to
aefe6a6
Compare
|
/bot run |
|
PR_Github #18001 [ run ] triggered by Bot |
|
PR_Github #18001 [ run ] completed with state |
chzblych
force-pushed
the
yanchaol-upload
branch
from
aefe6a6 to
5eeee25
Compare
|
/bot run |
|
PR_Github #18008 [ run ] triggered by Bot |
|
PR_Github #18008 [ run ] completed with state |
chzblych
force-pushed
the
yanchaol-upload
branch
2 times, most recently
from
c25db71 to
b17025d
Compare
|
/bot run |
|
PR_Github #18030 [ run ] triggered by Bot |
|
PR_Github #18030 [ run ] completed with state |
chzblych
force-pushed
the
yanchaol-upload
branch
from
b17025d to
2f93e9d
Compare
|
/bot run |
|
PR_Github #18053 [ run ] triggered by Bot |
|
PR_Github #18053 [ run ] completed with state |
|
/bot run |
|
PR_Github #18065 [ run ] triggered by Bot |
|
PR_Github #18065 [ run ] completed with state |
…collection Signed-off-by: Yanchao Lu <[email protected]>
chzblych
force-pushed
the
yanchaol-upload
branch
from
2f93e9d to
10c4c21
Compare
2 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.