Skip to content

Conversation

@byshiue
Copy link
Collaborator

@byshiue byshiue commented Sep 8, 2025

Summary by CodeRabbit

  • Tests
    • Updated MMLU accuracy baselines for Qwen3 30B A3B under FP8 and NVFP4 (with FP8 KV cache) to reflect current results.
    • Left other related baselines unchanged to preserve comparability.
    • Improves test reliability by aligning expectations with observed performance and reducing false negatives in CI.
  • Chores
    • No functional changes to end-user features; adjustments limited to test expectations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@byshiue
Copy link
Collaborator Author

byshiue commented Sep 8, 2025

/bot skip --comment "only relax the threshold of CI"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

📝 Walkthrough

Walkthrough

Adjusted two MMLU accuracy reference values for Qwen3/Qwen3-30B-A3B in the integration test YAML: FP8/FP8 and NVFP4/FP8 entries changed from 80.65 to 79.53. Other related entries remain unchanged.

Changes

Cohort / File(s) Summary
Test accuracy references
tests/integration/defs/accuracy/references/mmlu.yaml
Updated two accuracy values for Qwen3/Qwen3-30B-A3B: FP8 with kv_cache FP8 and NVFP4 with kv_cache FP8 from 80.65→79.53; W4A8_MXFP4_FP8 and W4A8_MXFP4_MXFP8 unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • litaotju
  • Shixiaowei02
  • brb-nv
  • yilin-void
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/integration/defs/accuracy/references/mmlu.yaml (1)

212-214: LGTM: NVFP4/FP8 threshold aligned to measured baseline.

Lowering to 79.53 matches the base entry and should reduce flakiness. Consider adding a YAML comment with the NVBug ID for future context.

-    accuracy: 79.53
+    accuracy: 79.53  # NVBug 5506683, PR #7604
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9dca69 and 9816614.

📒 Files selected for processing (1)
  • tests/integration/defs/accuracy/references/mmlu.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/defs/accuracy/references/mmlu.yaml (1)

209-213: Incorrect FP8 threshold concern The mmlu.yaml entry uses quant_algo: FP8_BLOCK_SCALES (not FP8) and its accuracy (79.53) wasn’t modified—only the NVFP4 threshold changed, so the FP8 inquiry can be disregarded.

Likely an incorrect or invalid review comment.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17993 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17993 [ skip ] completed with state SUCCESS
Skipping testing for commit 9816614

@byshiue byshiue changed the title [https://nvbugs/5506683][fix] adjust the mmlu threshold of TestQwen3_30B_A3B::test_nvfp4 [https://nvbugs/5506683][fix] adjust the CI Sep 8, 2025
@byshiue byshiue merged commit 219e955 into NVIDIA:main Sep 8, 2025
7 of 11 checks passed
@byshiue byshiue deleted the fix/nvbug_5506683 branch September 8, 2025 07:41
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants