Skip to content

Conversation

@moraxu
Copy link
Collaborator

@moraxu moraxu commented Oct 9, 2025

Description

The initial PR #6806 that introduced LoRa Torch tests for some models, consisted of comparing a model's output against a reference output that I provided as part of my initial local test runs. It appears that some results are non-deterministic on H100, for the test_nemotron_nano_8b_lora_torch as per https://nvbugspro.nvidia.com/bug/5563469 which I can't reproduce locally. I'm disabling the L0 test for now to unblock pipelines and will evaluate the non-determinism as part of https://jirasw.nvidia.com/browse/TRTLLM-7885 shortly

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Tests

    • Temporarily disabled a flaky Nemotron-Nano-8B test in the H100 pre-merge suite to reduce non-deterministic CI failures; added context comments and a tracking issue reference. No impact on product functionality.
  • Chores

    • Improved CI stability by excluding a known unreliable test, helping reduce false negatives and speeding up merges.

@moraxu
Copy link
Collaborator Author

moraxu commented Oct 9, 2025

/bot run --post-merge

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

📝 Walkthrough

Walkthrough

A single YAML test list was modified to comment out the Nemotron-Nano-8B test entry for the H100 suite, adding inline comments noting a non-deterministic failure and an issue reference. No other files or test entries were changed.

Changes

Cohort / File(s) Summary
Test list adjustments
tests/integration/test_lists/test-db/l0_h100.yml
Commented out Nemotron-Nano-8B test entry; added comments with failure reason and issue ID. No other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provides a clear narrative of the issue and its resolution but does not adhere to the repository template because it omits the required @coderabbitai summary header and leaves the Test Coverage section empty. Please include or remove the summary placeholder at the top and populate the Test Coverage section with the relevant tests that cover this change or a justification for why no additional tests are needed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title follows the repository’s naming conventions by including the NVBugs ID, the “[fix]” label, and a concise statement of the core change to disable a specific test due to non-determinism, making it clear and directly relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c88913d and 4bd139a.

📒 Files selected for processing (1)
  • tests/integration/test_lists/test-db/l0_h100.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/test-db/l0_h100.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20825 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20825 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15746 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Oct 9, 2025

/bot run --post-merge

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20844 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20844 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15763 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Oct 9, 2025

/bot run --post-merge

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20921 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20921 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15823 completed with status: 'FAILURE'

Signed-off-by: Michal Guzek <[email protected]>
@moraxu moraxu force-pushed the dev-mguzek-disable-nemotron-nano-lora-torch-test branch from 4bd139a to d3679c0 Compare October 9, 2025 20:11
@moraxu
Copy link
Collaborator Author

moraxu commented Oct 9, 2025

/bot run --post-merge

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20924 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20924 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15826 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Oct 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21052 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21052 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15913 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@MartinMarciniszyn MartinMarciniszyn merged commit 1cdb0b6 into NVIDIA:main Oct 14, 2025
5 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
…8b_lora_torch in L0 due to Torch non-determinism (NVIDIA#8206)

Signed-off-by: Michal Guzek <[email protected]>
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
…8b_lora_torch in L0 due to Torch non-determinism (NVIDIA#8206)

Signed-off-by: Michal Guzek <[email protected]>
Signed-off-by: yufeiwu-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
…8b_lora_torch in L0 due to Torch non-determinism (NVIDIA#8206)

Signed-off-by: Michal Guzek <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
…8b_lora_torch in L0 due to Torch non-determinism (NVIDIA#8206)

Signed-off-by: Michal Guzek <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
…8b_lora_torch in L0 due to Torch non-determinism (NVIDIA#8206)

Signed-off-by: Michal Guzek <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
…8b_lora_torch in L0 due to Torch non-determinism (NVIDIA#8206)

Signed-off-by: Michal Guzek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants