Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 23, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added skip entries for two tests to the waives list.

@xinhe-nv xinhe-nv marked this pull request as ready for review October 24, 2025 02:56
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251024_LLM_FUNCTION_TEST_1560 branch from b1bcf2b to 81e045c Compare October 24, 2025 02:56
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

📝 Walkthrough

Walkthrough

Two test cases are added to the waives list to be skipped: a KV cache aware router test for TinyLlama and a multimodal quickstart test for Qwen2.5-VL-7B. These are pure additive changes to the test waiver manifest with no logic modifications.

Changes

Cohort / File(s) Summary
Test Waiver List
tests/integration/test_lists/waives.txt
Added two SKIP entries: test case for workers KV cache aware router with TinyLlama-1.1B-Chat-v1.0 and test case for PTP quickstart multimodal with Qwen2.5-VL-7B-Instruct

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is severely incomplete and does not follow the required template structure. The description only contains three words ("waive failed cases.") and is missing critical sections including a detailed Description explaining the issue and solution, a Test Coverage section identifying the relevant tests being waived, and the PR Checklist required by the template. While the raw summary indicates two specific test cases are being added, the PR description provides no context about why these tests are failing or why they need to be waived, making it largely insufficient for reviewers to understand the rationale behind the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][chore] Add failed cases into waives.txt" clearly and accurately describes the main change in the changeset. The title directly corresponds to the primary action of adding two new SKIP entries to the waives.txt file, which matches the summary of changes. The title follows the required format and is concise and specific enough for developers to understand the core purpose of the change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f448043 and 81e045c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

391-392: Straightforward test waiver additions.

Both new entries follow the established pattern and format of the file. The test identifiers are well-formed with proper pytest parameter syntax, and the bug references use the standard nvbugs URL format.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22361 [ run ] triggered by Bot. Commit: 81e045c

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251024_LLM_FUNCTION_TEST_1560 branch from 81e045c to fa99c4b Compare October 24, 2025 04:45
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22361 [ run ] completed with state SUCCESS. Commit: 81e045c
/LLM/main/L0_MergeRequest_PR pipeline #16857 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251024_LLM_FUNCTION_TEST_1560 branch from fa99c4b to 8c869f2 Compare October 24, 2025 05:35
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 24, 2025 05:35
@xinhe-nv xinhe-nv requested a review from jieli-matrix October 24, 2025 05:35
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22380 [ reuse-pipeline ] triggered by Bot. Commit: 8c869f2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22380 [ reuse-pipeline ] completed with state SUCCESS. Commit: 8c869f2
Reusing PR_Github #22361 (Partly Tested) for commit 8c869f2

@xinhe-nv xinhe-nv merged commit 9a9d647 into NVIDIA:main Oct 24, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251024_LLM_FUNCTION_TEST_1560 branch October 24, 2025 06:19
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants