[https://nvbugs/5568836][fix] Skip keyword matching for Gemma3 e2e test

[brb-nv]

Description

Keyword matching in e2e multimodal tests is flaky (w.r.t dependency changes) for many models. There's a recent change which replaces these with MMMU accuracy benchmarking tests. However, these tests are on main and moving them to the release branch at this moment is not desirable. Proposed solution:

• Skip keyword matching on release/1.1 making these tests just smoke tests - this is what this MR is doing.
• Replace keyword matching with MMMU benchmarking on main.

Alternatively, we can only do the changes on main and relnote that keyword matching could be flaky and not create any new bugs along these lines for release branch.

Test Coverage

Existing tests. They just become smoke tests.

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Release Notes

• Tests
  • Updated integration test validation flow for multimodal models
  • Added smoke-test guards to streamline test execution
  • Modified keyword matching validation for specific model configurations to improve test efficiency
  • Adjusted test assertions to support refined validation patterns

[coderabbitai]

📝 Walkthrough

Walkthrough

The test suite is modified to treat gemma-3-27b-it model runs as smoke tests, skipping detailed keyword validation. The changes remove gemma-3-27b-it from expected keyword dictionaries and insert early-return paths after model execution, allowing other models' validation logic to remain unchanged.

Changes

Cohort / File(s)	Summary
E2E test modifications for gemma-3-27b-it smoke testing tests/integration/defs/test_e2e.py	Removed gemma-3-27b-it keyword matching expectations from multimodal quickstart tests. Added smoke-test early-return guards following model execution to skip keyword validation, replaced strict assertions with print-and-return paths for gemma-3-27b-it, and removed gemma-3-27b-it entries from expected_keywords dictionaries across multiple test variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify smoke test control flow: Ensure early-return paths don't inadvertently skip test reporting or coverage metrics
• Check other model validation: Confirm keyword assertions for non-gemma-3-27b-it models remain intact and unaffected
• Test naming consistency: Verify smoke test paths are clearly identifiable and don't obscure which assertions were skipped

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the main change: skipping keyword matching for Gemma3 e2e tests, which directly aligns with the primary objective of the PR.
Description check	✅ Passed	The PR description clearly explains the issue (flaky keyword matching), the solution (skip keyword matching for smoke tests on release/1.1), and the broader context (MMMU tests on main).

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/integration/defs/test_e2e.py (1)

3246-3250: Minor redundancy: output printed twice for gemma-3-27b-it.

Line 3245 already prints the output with print("output:", output), so the print at line 3249 is redundant. Consider removing it.

Apply this diff to remove the redundant print:

     # For gemma-3-27b-it, we only smoke test the model. Keyword matching is flaky.
     if model_name == "gemma-3-27b-it":
         print(f"Skipping keyword matching test for {model_name}. Smoke test completed successfully.")
-        print("output:", output)
         return

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e9409c and 390e5b4.

📒 Files selected for processing (1)

• tests/integration/defs/test_e2e.py (3 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: djns99
Repo: NVIDIA/TensorRT-LLM PR: 6915
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:4010-4012
Timestamp: 2025-08-14T23:23:27.449Z
Learning: For MOE (Mixture of Experts) code reviews in TensorRT-LLM, avoid repeatedly suggesting finalize fusion validation checks and safety assertions. The user djns99 has indicated these suggestions are repetitive and unwanted across multiple MOE-related changes.

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

• tests/integration/defs/test_e2e.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (2)

tests/integration/defs/test_e2e.py (2)

2618-2622: LGTM: Smoke test implementation for gemma-3-27b-it is correct.

The early return correctly bypasses keyword validation while still executing the model to verify it runs without crashes. The explanatory message and output logging provide good visibility.

---

3136-3140: LGTM: Consistent smoke test implementation for 2GPU variant.

The implementation follows the same pattern as the single-GPU test, ensuring consistency across test variants.

[brb-nv]

/bot run

[tensorrt-cicd]

PR_Github #24505 [ run ] triggered by Bot. Commit: 3bfc362

[tensorrt-cicd]

PR_Github #24505 [ run ] completed with state SUCCESS. Commit: 3bfc362
/LLM/release-1.1/L0_MergeRequest_PR pipeline #489 completed with status: 'FAILURE'

[brb-nv]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #24573 [ run ] triggered by Bot. Commit: 3bfc362

[tensorrt-cicd]

PR_Github #24573 [ run ] completed with state SUCCESS. Commit: 3bfc362
/LLM/release-1.1/L0_MergeRequest_PR pipeline #493 completed with status: 'SUCCESS'