Skip to content

[None][fix] Fix triton moe load_weight #9649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuyixiong merged 1 commit into from
Dec 6, 2025
Merged

[None][fix] Fix triton moe load_weight #9649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,11 +1397,7 @@ def load_weights(self,
assert len(weights) == 1
weights = weights[0]

self.quant_method.load_weights(
self,
weights,
self.weight_loading_mode,
allow_partial_loading=allow_partial_loading)
self.quant_method.load_weights(self, weights, self.weight_loading_mode)

def post_load_weights(self):
self.quant_method.post_load_weights(self)
23 changes: 10 additions & 13 deletions tensorrt_llm/_torch/modules/fused_moe/quantization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,17 +332,17 @@ def load_weights(self,
weights: List[Dict],
weight_loading_mode: MoEWeightLoadingMode,
allow_partial_loading: bool = False):
additional_kargs = {}
if "allow_partial_loading" in inspect.getfullargspec(
self.load_expert_weights_to_dst).args:
additional_kargs["allow_partial_loading"] = allow_partial_loading

self.load_expert_weights_to_dst(
module,
weights,
weight_loading_mode,
module.initial_local_expert_ids,
module.w3_w1_weight.data,
module, weights, weight_loading_mode,
module.initial_local_expert_ids, module.w3_w1_weight.data,
module.w2_weight.data,
module.w3_w1_bias.data if module.bias else None,
module.w2_bias.data if module.bias else None,
allow_partial_loading=allow_partial_loading)
module.w2_bias.data if module.bias else None, **additional_kargs)

self.load_quant_scales(module, weights)

Expand Down Expand Up @@ -397,15 +397,12 @@ def load_weights(self,
setattr(module, 'local_shared_w2_bias_tensors',
local_shared_w2_bias_tensors)
self.load_expert_weights_to_dst(
module,
weights,
weight_loading_mode,
local_shared_load_expert_ids,
local_shared_w3_w1_tensors,
module, weights, weight_loading_mode,
local_shared_load_expert_ids, local_shared_w3_w1_tensors,
local_shared_w2_tensors,
local_shared_w3_w1_bias_tensors if module.bias else None,
local_shared_w2_bias_tensors if module.bias else None,
allow_partial_loading=allow_partial_loading)
**additional_kargs)

def post_load_weights(self, module: torch.nn.Module):
if self.need_load_shared_weights(module):
Expand Down
Loading