feat(cli): add dynamic shell completion for flag values (#339)

[lockwobr]

Summary

Closes #339

• Add CompletableFlag wrapper that co-locates completion values with flag definitions, ensuring completions stay in sync with accepted values
• Extend completeWithAllFlags to emit flag values when the user TABs after an enum flag
• Wire completions for --intent, --service, --accelerator/--gpu, --os, --platform, --format, --deployer,
  --min-trust-level
• Add GetTrustLevels() getter to verifier package (was the only enum type missing one)

Test plan

• go test -race ./pkg/cli/... — 30 test cases pass including 6 new flag value completion tests
• go test -race ./pkg/bundler/verifier/... — TestGetTrustLevels passes
• Manual verification: aicr recipe --intent "" --generate-shell-completion outputs inference, training
• make qualify passes

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Refactoring (no functional changes)
• Build/CI/tooling

Component(s) Affected

• CLI (cmd/aicr, pkg/cli)
• API server (cmd/aicrd, pkg/api, pkg/server)
• Recipe engine / data (pkg/recipe)
• Bundlers (pkg/bundler, pkg/component/*)
• Collectors / snapshotter (pkg/collector, pkg/snapshotter)
• Validator (pkg/validator)
• Core libraries (pkg/errors, pkg/k8s)
• Docs/examples (docs/, examples/)
• Other: ____________

Implementation Notes

Testing

# Commands run (prefer `make qualify` for non-trivial changes)
make qualify

Risk Assessment

• Low — Isolated change, well-tested, easy to revert
• Medium — Touches multiple components or has broader impact
• High — Breaking change, affects critical paths, or complex rollout

Rollout notes:

Checklist

• Tests pass locally (make test with -race)
• Linter passes (make lint)
• I did not skip/disable tests to make CI green
• I added/updated tests for new functionality
• I updated docs if user-facing behavior changed
• Changes follow existing patterns in the codebase
• Commits are cryptographically signed (git commit -S) — GPG signing info

[github-actions]

Coverage Report ✅

Metric	Value
Coverage	74.4%
Threshold	70%
Status	Pass

Coverage Badge

![Coverage](https://img.shields.io/badge/coverage-74.4%25-green)

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/aicr/pkg/bundler/verifier	63.79% (+0.80%)	👍
github.com/NVIDIA/aicr/pkg/cli	35.99% (+2.30%)	👍

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/aicr/pkg/bundler/verifier/trust.go	77.55% (+2.55%)	49 (+5)	38 (+5)	11	👍
github.com/NVIDIA/aicr/pkg/cli/bundle.go	0.72% (ø)	139	1	138
github.com/NVIDIA/aicr/pkg/cli/bundle_verify.go	36.21% (+1.12%)	58 (+1)	21 (+1)	37	👍
github.com/NVIDIA/aicr/pkg/cli/completion_values.go	100.00% (+100.00%)	13 (+13)	13 (+13)	0	🌟
github.com/NVIDIA/aicr/pkg/cli/recipe.go	76.54% (ø)	81	62	19
github.com/NVIDIA/aicr/pkg/cli/root.go	70.41% (+1.36%)	98 (+14)	69 (+11)	29 (+3)	👍
github.com/NVIDIA/aicr/pkg/cli/snapshot.go	5.00% (ø)	40	2	38

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

[yuanchen8911]

Cross-Review Summary for PR #512

Reviewers: Claude Code, Codex, CodeRabbit + Integration Analysis
Rounds: 1
Consensus reached: Yes

Confirmed Issues

#	Severity	Finding	Confirmed By
1	Low	query.go:39 type assertion fragile — f.(*cli.StringFlag) targets outputFlag (currently unwrapped, safe). If outputFlag is ever wrapped with withCompletions, this assertion silently fails and --output leaks into the query command. Recommend using f.Names() check instead.	Codex + CodeRabbit + Integration

Positive Observations

• Clean CompletableFlag interface design — extends cli.Flag via embedding, preserves all existing interface methods
• Lazy func() []string completions always return current values from source of truth
• formatFlag var → func eliminates shared mutable state in parallel tests
• shellCompletionFlag constant replaces 4 string literals
• 135 lines of new tests covering all completion paths, alias resolution, and cross-command inheritance
• Both bash and zsh/fish shell paradigms explicitly handled and documented

---

Cross-review by Claude Code + Codex + CodeRabbit

[yuanchen8911]

/lgtm