fix(bundler): resolve ArgoCD RepoURL placeholder in child applications#520
Merged
Conversation
#519) Replace escaped Go template placeholder {{ .RepoURL }} in child application.yaml with actual repo URL passed through ApplicationData. ArgoCD's directory-based app-of-apps does not template-render discovered files, so the literal string was used as a Git URL causing ComparisonError. Also auto-derive RepoURL and TargetRevision from OCI reference when using --deployer argocd with OCI output, making --repo optional.
lalitadithya
approved these changes
Apr 9, 2026
Contributor
Coverage Report ✅
Coverage BadgeMerging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #519
{{ .RepoURL }}literal placeholder in ArgoCD childapplication.yamlfiles. ArgoCD's directory-based app-of-apps does not template-render discovered files, so the escaped Go template string was used as a Git URL, causingComparisonError.RepoURLandTargetRevisionthroughApplicationDatato each child application template.RepoURLandTargetRevisionfrom OCI reference when using--deployer argocdwith OCI output (-o oci://...), making--repoflag optional in that case.Test plan
{{ .RepoURL }})WithTargetRevisiongetter/optionmake lintpassesaicr bundle --recipe recipe.yaml --deployer argocd --output oci://...generates correct child application.yaml with OCI repo URL and tag