fix(bundler): demote nodewright selector warnings to info severity#704
Merged
Conversation
) Add "info" severity tier to the bundler validation framework. Info-level validations are logged via slog.Info (visible with --debug) but not surfaced as deployment warnings, reducing noise for first-time users. Demote both nodewright-customizations selector checks from "warning" to "info" in registry.yaml.
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Coverage Report ✅
Coverage BadgeMerging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Include validation.Function and validation.Message in the slog.Info call for checkErrors in the info severity path, matching the context available in the warning/error paths for traceability.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lalitadithya
approved these changes
Apr 28, 2026
lockwobr
approved these changes
Apr 28, 2026
lockwobr
pushed a commit
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
infoseverity tier to the bundler validation framework and demote both nodewright-customizations selector warnings fromwarningtoinfo. Info-level messages are logged viaslog.Info(visible with--debug) but no longer surfaced as deployment warnings.Motivation / Context
Every
aicr bundle --intent trainingemits two nodewright warnings about missing--workload-selectorand--accelerated-node-selectorregardless of context. This universal-fire noise dilutes real warnings.Fixes: #686
Related: N/A
Type of Change
Component(s) Affected
pkg/bundler,pkg/component/*)pkg/recipe)Implementation Notes
"info"case to the severity switch inRunValidations()(pkg/bundler/validations/registry.go). Info-severity check results are logged viaslog.Infobut not appended to returned warnings/errors.recipes/registry.yamlfromseverity: warningtoseverity: info.TestComponentRegistry_Validationsinpkg/recipe/components_test.goto expect the new severity.RunValidations().Testing
pkg/bundler/validations: ALL PASS (including 2 new info-severity test cases)pkg/recipe: ALL PASSgolangci-lint: 0 issues on changed packagespkg/trust(Sigstore TUF) andpkg/bundler/deployer/helm(mktemp) are unrelatedCoverage:
pkg/bundler/validationsmaintains existing coverage with 2 additional test cases.Risk Assessment
Rollout notes: N/A — advisory messages move from deployment notes to debug log; no behavioral change for bundle generation.
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info