fix: update license check#713
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workflow .github/workflows/merge-gate.yaml no longer invokes Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Makefile`:
- Around line 164-165: The Makefile contains --ignore flags for
github.com/hashicorp/go-cleanhttp and github.com/hashicorp/go-retryablehttp
which bypass the license gate; remove those
--ignore=github.com/hashicorp/go-cleanhttp,github.com/hashicorp/go-retryablehttp
entries or instead add MPL-2.0 to the --allowed_licenses list (the
--allowed_licenses and --ignore flags are the unique symbols to edit) so the
license check is not circumvented and the MPL-2.0-licensed modules are handled
explicitly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: a71c8e25-e30a-4b5e-b670-86198f048567
📒 Files selected for processing (2)
.github/workflows/merge-gate.yamlMakefile
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
Summary
Make ci use the same logic for check.
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info