fix(ci): trigger H100 GPU tests on shared recipe changes#717
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files were modified to expand path-based triggers. In .github/workflows/gpu-h100-inference-test.yaml the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
2568d53 to
ac40c0d
Compare
Summary
Trigger the real nvkind H100 GPU workflows when shared recipe data changes.
Motivation / Context
#715 changes
recipes/registry.yamlandrecipes/overlays/base.yaml, but the H100 nvkind GPU workflows skipped because their path filters only matched narrower kind/H100 overlay and component paths. Shared recipe surfaces affect the rendered H100 kind bundles and should not bypass real GPU coverage.recipes/data.gois also part of this surface because it defines the embedded recipe filesystem used by the CLI that the H100 jobs build before generating the runtime bundle.Fixes: N/A
Related: #715
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Adds shared H100 bundle inputs to both H100 GPU workflow path filters:
recipes/data.gorecipes/registry.yamlrecipes/overlays/base.yamlThe filter stays focused on inputs the PR-triggered H100 kind runtime jobs actually consume. Example-only changes, recipe health-check fixtures, and non-kind OS mixins remain out of the expensive GPU gate.
Testing
Full
make qualifyskipped: this is an infra-only workflow path-filter change with no runtime code changes.Risk Assessment
Rollout notes: Merge before rebasing #715 so its push mirror picks up the corrected H100 workflow filters.
Checklist
make testwith-race) (N/A — workflow-only CI path-filter change)make lint) (actionlintscoped to changed workflows)git commit -S) — GPG signing info