feat(recipes): pin nfd and k8s-ephemeral-storage-metrics chart versions#758
Merged
Conversation
First pass of #749. Closes the chart-version pinning gap for the two external (non-NVIDIA-owned) helm components, where no policy decision under #742 is needed: - nfd: node-feature-discovery 0.18.3 - k8s-ephemeral-storage-metrics: 1.19.2 Both versions are the current upstream stable. Verified that our existing values.yaml shapes still render against the pinned versions and the resulting image set is unchanged (1 image each in the BOM). NVIDIA-owned charts (gpu-operator, network-operator, nvidia-dra-driver-gpu, nodewright-operator) remain unpinned pending the #742 policy outcome and will land in a follow-up. Refs #749, #739
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
lalitadithya
approved these changes
May 5, 2026
Contributor
|
/lgtm |
This was referenced May 5, 2026
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First pass of #749 (Phase A). Pins chart versions for the two external helm components, where no policy decision under #742 is needed.
Motivation / Context
Today these two charts have no
defaultVersioninrecipes/registry.yaml, so renders track upstream-latest non-deterministically — same recipe rendered today vs. next month can produce different image sets. Pinning closes that gap for the unblocked subset.NVIDIA-owned charts (
gpu-operator,network-operator,nvidia-dra-driver-gpu,nodewright-operator) remain unpinned pending the policy decision in #742 and will land in a follow-up Phase B.Fixes: (none) — partial progress on #749
Related: #739, #742
Type of Change
Component(s) Affected
recipes/registry.yaml)Implementation Notes
Versions chosen are the current upstream stable releases (
helm search repo --versions):node-feature-discovery: 0.18.3k8s-ephemeral-storage-metrics: 1.19.2Verified that our existing
values.yamlshapes still render cleanly against the pinned versions (no value-key drift). The resulting image sets are unchanged — 1 image per component, matching pre-pin output.make bomafter the change:Testing
make bomproduces the same 71-image inventory across 22 components — pinning these two doesn't change the deployed image set, just locks in determinism.Risk Assessment
recipes/registry.yaml. Both versions verified to render against existing values. No image-set delta. Easy to revert if a downstream regression surfaces.Rollout notes: none.
Checklist
make testwith-race)make lint)make bom)git commit -S)