Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Enable more warning flags. #249

Merged
alliepiper merged 11 commits into from
Feb 16, 2021
Merged

Enable more warning flags. #249

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39a2172
Name unnamed structs.
alliepiper Dec 8, 2020
4b59207
Fix assorted shadowed variable warnings.
alliepiper Dec 10, 2020
d182eef
warning C4706: assignment within conditional expression
alliepiper Dec 10, 2020
f61bc46
Replace deprecated `cudaThreadSynchronize()` calls.
alliepiper Dec 10, 2020
e4591c1
Suppress deprecation warnings for TexRefInputIterator.
alliepiper Dec 10, 2020
541916b
warning C4310: cast truncates constant value.
alliepiper Dec 10, 2020
e9d77ab
Fix C++17 + NVCC + MSVC + CMake.
alliepiper Jan 22, 2021
c353fce
Fix numeric conversion warnings.
alliepiper Jan 22, 2021
b7207a2
Enable more compiler warning flags.
alliepiper Nov 11, 2020
63e2ad4
Add cub::DivideAndRoundUp helper to avoid overflow.
alliepiper Feb 9, 2021
e0a6736
Refactor GridEvenShare::total_tiles to int32.
alliepiper Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppress deprecation warnings for TexRefInputIterator. 
We need to deprecate this class since the underlying CUDA APIs
are deprecated. This suppression is a temporary workaround.

Tracked by #191.
  • Loading branch information
@alliepiper
alliepiper committed Feb 10, 2021
commit e4591c1e38ee09f1b94988988dff82f980e0d326
20 changes: 20 additions & 0 deletions cub/iterator/tex_ref_input_iterator.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@
#include "../util_debug.cuh"
#include "../config.cuh"

// This class needs to go through a deprecation cycle and be removed, as the
// underlying cudaBindTexture / cudaUnbindTexture APIs are deprecated.
// See issue NVIDIA/cub#191.
// Turn off deprecation warnings when compiling this file until then.
#if CUB_HOST_COMPILER == CUB_HOST_COMPILER_MSVC
#pragma warning(disable:4996)
#elif CUB_HOST_COMPILER == CUB_HOST_COMPILER_GCC || \
CUB_HOST_COMPILER == CUB_HOST_COMPILER_CLANG
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Copy link
Collaborator

@brycelelbach brycelelbach Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would deprecate or remove this entirely.

Copy link
Collaborator Author

@alliepiper alliepiper Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#191

#if (CUDART_VERSION >= 5050) || defined(DOXYGEN_ACTIVE) // This iterator is compatible with CUDA 5.5 and newer

#if (THRUST_VERSION >= 100700) // This iterator is compatible with Thrust API 1.7 and newer
Expand Down Expand Up @@ -377,3 +389,11 @@ public:
CUB_NS_POSTFIX // Optional outer namespace(s)

#endif // CUDART_VERSION

// Re-enable deprecation warnings:
#if CUB_HOST_COMPILER == CUB_HOST_COMPILER_MSVC
#pragma warning(default:4996)
#elif CUB_HOST_COMPILER == CUB_HOST_COMPILER_GCC || \
CUB_HOST_COMPILER == CUB_HOST_COMPILER_CLANG
#pragma GCC diagnostic pop
#endif