This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix clang / nvcc CI build #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
run tests |
Collaborator
|
@senior-zero for posterity, can you update the PR description with a summary of what we're doing here and why? |
jrhemstad
reviewed
Feb 28, 2023
gevtushenko
force-pushed
the
fix-main/github/ci
branch
from
3dd07fb to
11285ac
Compare
Collaborator
Author
|
run tests |
miscco
approved these changes
Feb 28, 2023
Collaborator
Author
|
run tests |
robertmaynard
suggested changes
Mar 1, 2023
robertmaynard
approved these changes
Mar 1, 2023
Collaborator
Author
|
run tests |
2 similar comments
Collaborator
Author
|
run tests |
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
fix-main/github/ci
branch
from
eb78818 to
1aab4d3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang has a builtin called
__is_signed. Unfortunately, libstdc++ headers use this name as an identifier. Clang has a workaround for that, it checks if__is_signedisconst static boolas in libstdc++ headers and if so, disables the intrinsic for the rest of the TU. For some reason, when clang is used as host compiler in nvcc, this workaround doesn't work. It's likely that some implicitly included headers affect first use of__is_signed.