This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Dereference iterator via get_value(derived_cast(exec),iterator) #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows peeking into the device data when exec is device policy
and the iterator is a raw device pointer, thus fixing
{min,max,minmax}_element in such setup.
Contributor
|
Thanks, it looks good. Could you also please include a note in the CHANGELOG about this fix (as well as your previous fix which I think we forgot to mention). |
This was referenced Apr 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #776
This allows peeking into the device data when exec is device policy
and the iterator is a raw device pointer, thus fixing
{min,max,minmax}_element in such setup.