Skip to content

DR-3790: Fix timeouts on homepage localhost tests #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbdalton merged 6 commits into from
Sep 19, 2025
Merged

DR-3790: Fix timeouts on homepage localhost tests #465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c558a2
trying some timeout options
jbdalton Sep 18, 2025
6cf13ab
add route-filters to block 3rd-party calls, change wait to load
jbdalton Sep 18, 2025
f8c9f39
dial overall timeout down to 30s but keep expect-timeouts at 20s for …
jbdalton Sep 18, 2025
0b34250
remove the scalpel
jbdalton Sep 18, 2025
27b42a9
make goto default
jbdalton Sep 19, 2025
fced17e
Update changelog
jbdalton Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove the scalpel
  • Loading branch information
@jbdalton
jbdalton committed Sep 18, 2025
commit 0b34250089141122560e007a5070226f100734cf
3 changes: 0 additions & 3 deletions playwright/pages/homepage.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,6 @@ export class DCHomepage {
this.footerAccessibilityLink = this.page.getByRole("link", {
name: "Accessibility",
});
this.footerPrivacyPolicyLink = this.page.getByRole("link", {
name: "Privacy Policy",
});

//feedback button
this.feedbackButton = this.page.getByRole("button", { name: "Feedback" });
Expand Down
6 changes: 3 additions & 3 deletions playwright/tests/homepage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ test("verify footer links are visible", async ({ page }) => {
page.setDefaultTimeout(30000); // 30 seconds
const dchomepage = new DCHomepage(page);
// the full footer content should be tested in the footer repo, not here in DC

await expect(dchomepage.footerAccessibilityLink).toBeVisible();
});

test("verify feedback button is visible", async ({ page }) => {
// With route-filtering on and domcontentload as a default,
// extending timeouts might not be necessary anymore for feedback button.
//page.setDefaultTimeout(60000); // 60 seconds
// With route-filtering on, extending timeouts might not be necessary
// for feedback button tests.
test.setTimeout(60000);

const dchomepage = new DCHomepage(page);
Expand Down