Consume fetch response body on error#468
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avertrees
approved these changes
Sep 25, 2025
sarangj
force-pushed
the
consume_response_body
branch
from
b67ae61 to
9159ba7
Compare
sarangj
force-pushed
the
consume_response_body
branch
from
9159ba7 to
4d7b706
Compare
Doing some digging, I read that a potential source of memory leaks is not consuming the response body of a fetch response. Noticed that we don't consume the body on error, so changed things up a bit to parse and log the text of the body if we don't get an ok response. Did a bit of refactoring as a part of this, namely, getting rid of the nested error handling and removing the 422 specific handling, which probably made sense when this was first written but now is probably fine to remove since we have a stabilized API.
sarangj
force-pushed
the
consume_response_body
branch
from
4d7b706 to
17b0ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some digging, I read that a potential source of memory leaks is not consuming the response body of a fetch response. Noticed that we don't consume the body on error, so changed things up a bit to parse and log the text of the body if we don't get an ok response.
Did a bit of refactoring as a part of this, namely, getting rid of the nested error handling and removing the 422 specific handling, which probably made sense when this was first written but now is probably fine to remove since we have a stabilized API.
Ticket:
This PR does the following:
Open questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: