Move searchType ga4 default to ga4 util

Move this into the ga4 utils and make search type possibly undefined to
clarify the contract.

app/src/components/pages/collectionPage/collectionPage.tsx

@@ -120,9 +120,9 @@ const CollectionPage = ({
   const analyticsData = collectionSearchManager.analyticsData;
   useEffect(() => {
     trackSearchResults(
-      analyticsData.searchType,
       analyticsData.searchResultsLayout,
       analyticsData.filterNames,
+      analyticsData.searchType,
       analyticsData.searchTerm
     );
   }, [JSON.stringify(analyticsData)]);

app/src/components/pages/collectionsPage/collectionsPage.tsx

@@ -95,9 +95,9 @@ export function CollectionsPage({ data, collectionsSearchParams }) {
   const analyticsData = collectionsSearchManager.analyticsData;
   useEffect(() => {
     trackSearchResults(
-      analyticsData.searchType,
       analyticsData.searchResultsLayout,
       analyticsData.filterNames,
+      analyticsData.searchType,
       analyticsData.searchTerm
     );
   }, [JSON.stringify(analyticsData)]);

app/src/components/pages/searchPage/searchPage.tsx

@@ -95,9 +95,9 @@ const SearchPage = ({
   const analyticsData = searchManager.analyticsData;
   useEffect(() => {
     trackSearchResults(
-      analyticsData.searchType,
       analyticsData.searchResultsLayout,
       analyticsData.filterNames,
+      analyticsData.searchType,
       analyticsData.searchTerm
     );
   }, [JSON.stringify(analyticsData)]);

app/src/utils/ga4Utils.ts

@@ -59,16 +59,16 @@ export const trackAVProgress = (
 };
 
 export const trackSearchResults = (
-  searchType: string,
   searchResultsLayout: "grid" | "list",
   filterNames: string[],
+  searchType?: string,
   searchTerm?: string
 ) => {
   const dataLayer = window["dataLayer"] || [];
   const layout = upperGridViewLayoutParam(searchResultsLayout);
   let data = {
     event: "view_search_results",
-    search_type: searchType,
+    search_type: searchType ?? "default",
     search_results_layout: layout,
   };
   if (searchTerm) {

app/src/utils/searchManager/searchManager.tsx

@@ -16,7 +16,7 @@ import { MutableRefObject } from "react";
 
 type AnalyticsData = {
   searchTerm?: string;
-  searchType: string;
+  searchType?: string;
   filterNames: string[];
   searchResultsLayout: "grid" | "list";
 };
@@ -113,15 +113,16 @@ abstract class BaseSearchManager implements SearchManager {
   get analyticsData(): AnalyticsData {
     const filters = this.filters;
     const filterNames = filters.map((f) => f.filter);
-    const searchType =
-      filters.find((f) => f.filter === "rights")?.value ?? "default";
-
-    return {
+    let data: AnalyticsData = {
       searchTerm: this.keywords ?? undefined,
-      searchType: searchType,
       filterNames: filterNames,
       searchResultsLayout: this.viewMode,
     };
+    const searchType = filters.find((f) => f.filter === "rights")?.value;
+    if (searchType) {
+      data.searchType = searchType;
+    }
+    return data;
   }
 
   handleKeywordChange(value: string) {