Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sarangj
force-pushed
the
ugh
branch
2 times, most recently
from
4d40c20 to
59f5659
Compare
This ensures we aren't relying on `window` on the server side.
Make the UV custom hook only load the uv library on the client side, as the import triggers calls to the window API.
Looks like the options only get pruned on the initial page render. Reading some UV code, I realized we could do this more simply by listening for the showOverlay event, which gets fired whenever an overlay is shown (of which the download dialogue is one). However, there is a small delay between the event being fired and the ui elements actually rendering, so I still need to attach a mutation observer here.
sarangj
changed the title
sarangj
commented
Apr 8, 2026
sarangj
commented
Apr 8, 2026
sarangj
commented
Apr 8, 2026
Add something explicit that spells out why we're not using the constants from the library.
keithbauer
approved these changes
Apr 8, 2026
keithbauer
reviewed
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
Reverts my previous 'fix' - it seems like dynamic loading still breaks the events system for some reason.
So instead, just do the simpler fix of not referencing the universalviewer library at the top level at all, opting for our own constants in the universalviewer component.
I also made the download dialogue pruning a bit more robust, to have it respond to the showOverlay event, so that the pruning fires every time a download overlay is rendered.
Open questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: