Add content type specific placeholder images to search#559
Merged
Conversation
Looks like the SearchCardImage doesn't know what props it is receiving, so add it in!
Pipe the contentType of the search result through the card props and use it to determine which placeholder image we render if no thumbnail is available.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sarangj
changed the title
sarangj
requested review from
avertrees,
emretetiknypl,
emu47 and
keithbauer
as code owners
keithbauer
approved these changes
Apr 28, 2026
keithbauer
left a comment
keithbauer
left a comment
Member
There was a problem hiding this comment.
nice!
also the image diff is pretty neat with Swipe and Onion Skin, don't think I've seen these before
Contributor
Author
|
yes, the diff view is so cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
Pipe the contentType of the search result through the card props and use
it to determine which placeholder image we render if no thumbnail is
available.
Open questions
How has this been tested? How should a reviewer test this?
Check out the lou reed papers to see audio and image placeholders:
Do a video specific search and scroll til you find a video without a thumbnail:
Accessibility concerns or updates
Checklist: