Repository navigation
fix(compose): forward extra models and idle unload knobs to laya-serve - #1053
Conversation
09da824 to
acc23b0
Compare
|
This PR is ready for review:
All CI pipelines across Python, TypeScript, Java, .NET, Docker, and CodeQL are now 100% green. Ready to merge when you get a chance! |
|
Merged.
Pinning the names as literals in One thing travelled with this PR that is not in its title, and it is the most important change in this batch. Commit Worth checking your branch point. This looks like it was cut from a fix branch rather than from Merged with #1054, which extends the same env-var tuple; both sets are kept. |
14 pull requests from 8 contributors. * the TypeScript tree parses again: an unterminated template literal shipped in 0.4.1 and stopped 22 of 34 test files loading (#1056) * x_jev_confidence on /v1/systemone, computed locally (#1066, #302) * a narrowed shortlist drops option_order with a warning instead of failing (#1063) * registering a name one edit from a built-in warns (#1055, #919) * compose forwards four knobs the runtime already read (#1053, #1054) * Java Router.predictBatch and Shortlist.predictTournament (#1060, #1061) * teacher-agreement evals, with the self-agreement ceiling (#1071, #919) Security: no malicious content found; the audit is recorded locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
What & Why
In
compose.http.yaml,LAYA_EXTRA_MODELSandLAYA_IDLE_UNLOAD_SECONDSwere not forwarded underenvironment:, causing Docker Compose to silently drop them when configured on the host.Fixes strict TypeScript compilation and packaging failures introduced in recent upstream commits:
laya-ts/src/hooks.ts: unclosed template literal inrunWithTimeouterror rejection.laya-ts/src/hooks.ts: missinghook?: Hookondispatchoptions interface.laya-ts/src/agent.ts:Object is possibly 'undefined'inpredictBatchwhen calculatingthis.hooksTimeout * 1000under strict null checks.Detailed Code Changes
compose.http.yaml:${LAYA_EXTRA_MODELS:-}and${LAYA_IDLE_UNLOAD_SECONDS:-}host passthroughs tolaya-serve.docs/docker.md:tests/test_compose_env.py:laya-ts/src/hooks.ts:runWithTimeout.hook?: Hooktodispatchopts interface.runWithTimeoutacceptunknownand returnPromise<void>to safely handle synchronous and asynchronous hook executions.laya-ts/src/agent.ts:timeoutMsviatypeof hooksTimeout === "number" ? hooksTimeout * 1000 : nullto eliminateTS2532and properly allow per-callopts.hooksTimeoutoverrides.Testing & Verification
python -m unittest tests/test_compose_env.py: 263 passed, 0 failed (+26 checks verified)python -m unittest tests/test_env_docs.py: 27 passed, 0 failedpython -m unittest tests/test_packaging.py: 138 passed, 0 failed