Repository navigation
fix(serve): a caller batch_size may shrink a pass, never widen one - #1332
Merged
NandhaKishorM merged 1 commit intoOct 24, 2026
Merged
Conversation
/v1/systemone/batch plans a batch_size from LAYA_MAX_BATCH_TOKENS so one forward pass
stays inside a token budget, but only when the body does not name one: any value the
caller sent was forwarded verbatim, with no upper bound. So the guard was opt-out by the
request it protects -- a 4 KB body of 64 states at max_len 8192 is 524 288 tokens, four
times the budget, and batch_size=10**18 sent it all in one pass.
The plan is now computed for every request and the caller's value is capped at it. A
smaller value is still honoured (asking for a narrower pass asks for less work), and a
request that already fits is still passed no batch_size at all, so the byte-identical
path is unchanged. The old test asserted the previous contract ('the caller asked for a
shape'); it now asserts both directions, and docs/http-api.md says which one wins.
4 tasks done
NandhaKishorM
added a commit
that referenced
this pull request
Oct 24, 2026
33 PRs. Server hardening (#1331, #1332, #1333), TypeScript parity (#1330, #1336, #1337, #1338, #1339, #1340, #1341, #1342, #1343), fail-closed input handling in evals and the integrations (#1317, #1318, #1319, #1320, #1321, #1322, #1326, #1335), exact and faster script detection (#1334, #1349), JVM and .NET resource handling (#1327, #1328, #1329, #1346), port goldens and clipping (#1324 excluded, #1325, #1344, #1345), CI (#1323, #1347, #1348). Verified before tagging: all 92 suites pass, 610 tests. ruff clean on both lists. laya-ts 1247 tests across 44 files, tsc --noEmit clean. Version agrees across pyproject.toml, laya.__version__ and nix/package.nix. README carries 0.4.15 only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/v1/systemone/batchcomputes the token-budget plan for every request and caps the caller'sbatch_sizeat it. A smaller value is still honoured; a request that already fits is still passed nobatch_sizeat all.The old contract ("the caller's own
batch_sizealways wins") is changed deliberately, anddocs/http-api.mdsays so.Why
The plan that keeps one forward pass inside
LAYA_MAX_BATCH_TOKENSwas only consulted when the body did not name abatch_size, and the validator had no upper bound.batch_size=10**18on a 4 KB body of 64 states atmax_len8192 collated 524 288 tokens in one pass -- four times the budget -- so the documented amplification guard was opt-out by the very request it protects against.How it was verified
Checklist
main(branch cut fromupstream/mainat 0.4.14)