Skip to content

Update README.md - #173

Closed
Mishva-vibe wants to merge 1 commit into
NandhaKishorM:mainfrom
Mishva-vibe:main
Closed

Mishva-vibe wants to merge 1 commit into
NandhaKishorM:mainfrom
Mishva-vibe:main

Conversation

@Mishva-vibe

Copy link
Copy Markdown

No description provided.

@NandhaKishorM

Copy link
Copy Markdown
Owner

Thank you for opening a PR, it's a great way to learn the workflow. This one only adds a practice line to the README, so I won't merge it. If you'd like a first real contribution, the "good first issue" kind of fixes in #117 and #118 (docs) are a nice place to start.

@NandhaKishorM

Copy link
Copy Markdown
Owner

Closing this one. As I said in September, it adds a practice line to the README, so there is nothing here to merge, and leaving it open does not help you.

No hard feelings in it, and opening a PR to learn the workflow is a reasonable thing to do. If you want a first real contribution, the docs issues are a good entry point and people do get them merged: #162 closed #117 and #118 today and started from a similar place.

A note that will save you time on the next one: the thing that gets a docs PR merged here is checking the facts in it against the code. #162 was held for a week because it said max_loaded defaults to 1 when the code says 2, and it merged once that was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants