Repository navigation
fix(packaging): include inference backends in wheels - #940
Conversation
|
Merged, and this turned out to be the most important fix in this batch. I checked the published artifact rather than taking the report at face value, and it is worse than a backend selection that could fail. On the wheel on PyPI today: So the whole backend selection API is absent for anyone who installed with pip, while The regression test is the part that earns its place. A hand-maintained This is going out as 0.3.28.
|
|
Correcting myself on one point in my comment above, because I named an API that does not exist and I would rather that not sit on the record. I wrote that The defect this PR fixes is real, and here it is measured correctly against the published 0.3.27 wheel in a clean virtualenv: So the accurate statement is narrower than what I wrote and still worth the release. The documented backend selection API, which Everything else stands. Your regression test is the part I would still highlight, and the correction reinforces it: I got the surface wrong by probing by hand, and a check that enumerates importable source packages and compares them with the declared list does not have that failure mode. |
28 pull requests from 12 contributors. The headline fix is #940: laya/backends was never in setuptools' package list, so the documented backend selection API has been unavailable to pip installs since 0.3.25. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Summary
laya.backendsin setuptools' explicit package list so inference backends ship in wheels and source distributionslayasource packageProblem
Source checkouts and editable installs exposed
laya.backends, but built distributions omitted it. As a result, backend selection could fail withModuleNotFoundErrorafter installing the published wheel.Verification
python tests/test_packaging.py- 138 passedpython -m buildpython -m twine checkon the wheel and source distributionlaya/backendsmodules are present--no-depsinto an isolated target and importedlaya.backendswithout the source tree onsys.path