Skip to content

feat: ada 3.1.1 including URLPattern support #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 10 commits into from
Feb 24, 2025
Merged

feat: ada 3.1.1 including URLPattern support #268

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23179c5
feat: ada v3
NathanWalker Jan 30, 2025
2736090
feat: use c++20
NathanWalker Jan 30, 2025
0ba17d9
Merge remote-tracking branch 'origin/main' into feat/ada-v3
NathanWalker Jan 30, 2025
3201e12
feat: ada 3.0.1
NathanWalker Jan 31, 2025
99fe6d0
feat: URLPattern
triniwiz Feb 12, 2025
c721359
fix: pattern test
triniwiz Feb 12, 2025
d932b9b
Merge branch 'main' into feat/ada-v3
NathanWalker Feb 12, 2025
7f0c488
fix: ensure URLPattern is registered
triniwiz Feb 23, 2025
0dc4c65
fix: hasRegExpGroups
NathanWalker Feb 24, 2025
2f3f98f
feat: Ada 3.1.1
NathanWalker Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: pattern test
  • Loading branch information
@triniwiz
triniwiz committed Feb 12, 2025
commit c7213590729a1ae3b2cabff02f06170c5bd9f990
8 changes: 4 additions & 4 deletions TestRunner/app/tests/URLPattern.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ describe("URLPattern", function () {
it("throws on invalid URLPattern", function () {
var exceptionCaught = false;
try {
const pattern = new URLPattern(null);
const pattern = new URLPattern(1);
} catch (e) {
exceptionCaught = true;
}
Expand All @@ -22,7 +22,7 @@ describe("URLPattern", function () {

it("parses simple pattern", function () {
const pattern = new URLPattern("https://example.com/books/:id");
expect(pattern.protocol).toBe("https:");
expect(pattern.protocol).toBe("https");
expect(pattern.hostname).toBe("example.com");
expect(pattern.pathname).toBe("/books/:id");
expect(pattern.port).toBe("");
Expand All @@ -36,13 +36,13 @@ describe("URLPattern", function () {

it("parses with undefined base", function () {
const pattern = new URLPattern("https://google.com", undefined);
expect(pattern.protocol).toBe("https:");
expect(pattern.protocol).toBe("https");
expect(pattern.hostname).toBe("google.com");
});

it("parses with null base", function () {
const pattern = new URLPattern("https://google.com", null);
expect(pattern.protocol).toBe("https:");
expect(pattern.protocol).toBe("https");
expect(pattern.hostname).toBe("google.com");
});

Expand Down
Loading