feat(payments): use string for response.code

packages/payments/index.android.ts

@@ -9,14 +9,9 @@ export class PaymentError extends Error {
     this.nativeError = nativeError;
   }
 
-  get code(): number {
-    return this.nativeError?.getCode() ?? Number.MAX_SAFE_INTEGER;
+  get code(): string {
+    return this.nativeError.getRaw();
   }
-
-  get subCode(): number {
-    return this.nativeError?.getSubCode() ?? Number.MAX_SAFE_INTEGER;
-  }
-
   get native(): any {
     return this.nativeError;
   }

packages/payments/index.d.ts

@@ -1,3 +1,11 @@
+export type FailureTypes = 'DEFERRED_PAYMENT' | 'PURCHASE_NOT_ALLOWED' | 'PRODUCT_UNAVAILABLE' | 'DEVELOPER_USAGE' | 'PRODUCT_ALREADY_OWNED' | 'PRODUCT_NOT_OWNED' | 'USER_CANCELLED' | 'NETWORK_AVAILABILITY' | 'BILLING_AVAILABILITY' | 'UNSPECIFIED' | 'SERVICE_DISCONNECTED' | 'SERVICE_TIMEOUT' | 'SERVICE_UNAVAILABLE' | 'FEATURE_NOT_SUPPORTED' | 'ERROR' | 'USER_INELIGIBLE' | 'INSUFFICIENT_FUNDS';
+
+export class PaymentError extends Error {
+  readonly code: FailureTypes;
+  readonly native: any;
+  readonly resolution: string;
+}
+
 export interface PurchaseOptions {
   accountId?: string;
   android?: {

packages/payments/index.ios.ts

@@ -8,12 +8,8 @@ export class PaymentError extends Error {
     this.nativeError = nativeError;
   }
 
-  get code(): number {
-    return this.nativeError?.code ?? Number.MAX_SAFE_INTEGER;
-  }
-
-  get subCode(): number {
-    return Number.MAX_SAFE_INTEGER;
+  get code(): string {
+    return this.nativeError.raw ?? 'UNSPECIFIED';
   }
 
   get native(): any {

packages/payments/platforms/android/java/org/nativescript/plugins/payments/Payments.kt

@@ -63,7 +63,45 @@ class Payments(context: Context) {
     val message: String,
     val resolution: String,
     val subCode: Int = Int.MAX_VALUE
-  )
+  ) {
+    val raw: String
+      get() {
+        if (subCode == BillingClient.OnPurchasesUpdatedSubResponseCode.USER_INELIGIBLE) {
+          return "USER_INELIGIBLE"
+        } else if (subCode == BillingClient.OnPurchasesUpdatedSubResponseCode.PAYMENT_DECLINED_DUE_TO_INSUFFICIENT_FUNDS) {
+          return "INSUFFICIENT_FUNDS"
+        }
+
+        return when (code) {
+          BillingClient.BillingResponseCode.OK -> "OK"
+
+          BillingClient.BillingResponseCode.BILLING_UNAVAILABLE -> "NETWORK_ERROR"
+
+          BillingClient.BillingResponseCode.NETWORK_ERROR -> "NETWORK_ERROR"
+
+          BillingClient.BillingResponseCode.USER_CANCELED -> "USER_CANCELED"
+
+          BillingClient.BillingResponseCode.ITEM_UNAVAILABLE -> "ITEM_UNAVAILABLE"
+
+          BillingClient.BillingResponseCode.DEVELOPER_ERROR -> "DEVELOPER_ERROR"
+
+          BillingClient.BillingResponseCode.FEATURE_NOT_SUPPORTED -> "FEATURE_NOT_SUPPORTED"
+
+          BillingClient.BillingResponseCode.ITEM_ALREADY_OWNED -> "ITEM_ALREADY_OWNED"
+
+          BillingClient.BillingResponseCode.ITEM_NOT_OWNED -> "ITEM_NOT_OWNED"
+
+          BillingClient.BillingResponseCode.SERVICE_UNAVAILABLE -> "SERVICE_UNAVAILABLE"
+
+          BillingClient.BillingResponseCode.SERVICE_DISCONNECTED -> "SERVICE_DISCONNECTED"
+
+          BillingClient.BillingResponseCode.SERVICE_TIMEOUT -> "SERVICE_TIMEOUT"
+
+          BillingClient.BillingResponseCode.ERROR -> "ERROR"
+          else -> "UNSPECIFIED"
+        }
+      }
+  }
 
   enum class Features(val value: String) {
     Subscriptions(BillingClient.FeatureType.SUBSCRIPTIONS),

packages/payments/platforms/ios/src/NSCPayment.swift

@@ -494,6 +494,33 @@ public enum NSCPaymentsResponseFailure: Int32, RawRepresentable {
       return 10
     }
   }
+
+  var stringValue: String {
+    switch self {
+    case .ProductUnavailable:
+      return "PRODUCT_UNAVAILABLE"
+    case .DeveloperUsage:
+      return "DEVELOPER_USAGE"
+    case .ProductAlreadyOwned:
+      return "PRODUCT_ALREADY_OWNED"
+    case .ProductNotOwned:
+      return "PRODUCT_NOT_OWNED"
+    case .UserCancelled:
+      return "USER_CANCELLED"
+    case .NetworkAvailability:
+      return "NETWORK_AVAILABILITY"
+    case .BillingAvailability:
+      return "BILLING_AVAILABILITY"
+    case .Unspecified:
+      return "UNSPECIFIED"
+    case .PurchaseNotAllowed:
+      return "PURCHASE_NOT_ALLOWED"
+    case .DeferredPayment:
+      return "DEFERRED_PAYMENT"
+    case .Error:
+      return "ERROR"
+    }
+  }
 }
 
 @objc(NSCPaymentsResponse)
@@ -512,6 +539,10 @@ public class NSCPaymentsResponse: NSObject {
     self.message = message
     self.resolution = resolution
   }
+
+  public var raw: String {
+    return code.stringValue
+  }
 }
 
 @objc(NSCPurchaseOptions)

packages/payments/typings/android.d.ts

@@ -33,6 +33,7 @@ declare module org {
             public getCode(): number;
             public getResolution(): string;
             public getSubCode(): number;
+            public getRaw(): string;
           }
           export class Companion {
             public static class: java.lang.Class<org.nativescript.plugins.payments.Payments.Companion>;

packages/payments/typings/objc!NSCPayments.d.ts

@@ -33,6 +33,8 @@ declare class NSCPaymentsResponse extends NSObject {
 
   readonly code: NSCPaymentsResponseFailure;
 
+  readonly raw: string;
+
   readonly message: string;
 
   readonly resolution: string;