Repository navigation
fix(h5): 释放 chooseMedia 加载失败的临时资源 - #19555
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughH5 Changes媒体加载失败时释放对象 URL
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19555 +/- ##
==========================================
+ Coverage 57.15% 57.22% +0.06%
==========================================
Files 467 467
Lines 25689 25693 +4
Branches 6407 6419 +12
==========================================
+ Hits 14683 14703 +20
+ Misses 9065 9050 -15
+ Partials 1941 1940 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
e6702ec to
bc6d670
Compare
这个 PR 做了什么?
H5
chooseMedia在图片解码、视频解码或视频文件读取失败时,会丢弃失败文件,却保留此前创建的 blob URL。现在统一捕获单文件加载失败并释放对应 URL,再沿用既有的失败文件丢弃策略;成功返回的图片 URL 保持可用。新增和扩展回归测试,覆盖混合成功失败、重复选择与重复错误、视频解码/读取错误,以及成功后迟到的错误不释放已返回的 URL。
Closes #19554
这个 PR 是什么类型?
这个 PR 涉及以下平台:
验证
pnpm --filter @tarojs/taro-h5 run test:ci --watchman=false:27 个测试文件、209 个用例全部通过。pnpm --filter @tarojs/taro-h5 run build:在完整执行环境下退出码为 0;构建仍存在未修改文件的既有类型与 Sass 等警告。git diff --check通过。Summary by CodeRabbit