You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The change makes interrupted H5 page scrolls settle once and lets a new scroll on the same target take over. The supplied evidence shows no concrete merge-blocking risk.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 284060cc-08c1-47bb-b6e7-f7a6debf275a
Commits
Reviewing files that changed from the base of the PR and between 4cee413 and d697f3a.
Files selected for processing: 2
packages/taro-h5/__tests__/ui/scroll.test.ts
packages/taro-h5/src/api/ui/scroll/index.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.51%. Comparing base (23d9147) to head (6b006cc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19617
这个 PR 做了什么?
按 Window 或页面容器记录正在运行的滚动。同一目标上的新调用取消前一个动画,并通过现有
MethodHandler.fail结算被替代的调用。新的零时长滚动也会取消旧动画,不同容器可各自完成滚动。失败或完成回调存在时沿用现有回调与 Promise 约定。只使用 Promise 时,被中断的调用以
pageScrollTo:fail interrupted by another scroll拒绝。取消回调同步发起新滚动时,最后发起的调用生效。这个 PR 是什么类型?
这个 PR 涉及以下平台?
验证
previewImage/ Swiper 类型告警及 Sass 弃用告警。验证使用 Jest/JSDOM。Summary by CodeRabbit