Repository navigation
fix(h5): prefer scrollTop in pageScrollTo - #19622
Single-Dancer merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. WalkthroughH5 ChangesH5 滚动参数优先级
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Possibly related PRs
Suggested reviewers: Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19622 +/- ##
========================================
Coverage 58.52% 58.53%
========================================
Files 470 470
Lines 26065 26067 +2
Branches 6541 6497 -44
========================================
+ Hits 15255 15258 +3
+ Misses 9014 8889 -125
- Partials 1796 1920 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6ac7740 to
58423af
Compare
Closes #19621
这个 PR 做了什么?
同时传入数值
scrollTop和selector时,按现有提示优先使用scrollTop。数值 0 也参与此判断。仅通过选择器定位时计算offsetTop。这个 PR 是什么类型?
这个 PR 涉及以下平台?
验证
scrollTop: 0与正数,共 4 个回归用例,原实现均失败,修复后均通过。previewImage/ Swiper 类型告警及 Sass 弃用告警。验证使用 Jest/JSDOM。Summary by CodeRabbit
0的情况。0。