This repository was archived by the owner on Jul 19, 2024. It is now read-only.
TC-17315 - EWS Library changes #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not our forked version, as the client has fixed the threading issues, see Apache HTTPCLIENT-1715 and HTTPCLIENT-1686
|
LGTM! |
|
LGTM. Glad to get rid of httpclient-netc :) |
jonlew90
approved these changes
Sep 21, 2017
|
Changes LGTM, but these should get merged to Edit: Actually, they should just point to |
Author
|
This is merging to master of ews-java-api, not TC |
|
I knew that 🤦♂️ Ignore me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change our fork of EWS library to use the latest Apache HTTP Client, and not our forked version, as the client has fixed the threading issues, see Apache HTTPCLIENT-1715 and HTTPCLIENT-1686 for Apache fix details.
This change points our Forked EWS library at HTTP Client 4.5.3, the latest, and updates our EWS client version to 2.0.1. The build artifacts of this have been uploaded to our S3 Maven repository.
Testing done - All with the ptr-belgium-gmail branch - build and test with my local build of this change. Run exchange connection test from UI, run Gmail connection test from UI, run exchange Integration tests, run gmail integration tests.
Requesting reviews from @trenner02 @jonlew90 @dspurling to increase our bus factor on our bespoke maven repository.