Fixed NPE on request cache when HystrixRequestContext is not initialized

[caarlos0]

I'm new to Hystrix, so I'm not sure this is the ideal implementation.

This might fix #995 .

[cloudbees-pull-request-builder]

NetflixOSS » Hystrix » Hystrix-pull-requests #350 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

NetflixOSS » Hystrix » Hystrix-pull-requests #351 SUCCESS
This pull request looks good

[cloudbees-pull-request-builder]

NetflixOSS » Hystrix » Hystrix-pull-requests #352 FAILURE
Looks like there's a problem with this pull request

[caarlos0]

Apparently there are unstable tests..

It also passed in Jenkins and travis... but int the last build, for some reason, these two tests failed:

• com.netflix.hystrix.HystrixCommandTest#testSemaphorePermitsInUse
• com.netflix.hystrix.HystrixCommandTest#testRequestCacheWithSlowExecution

Any tips?

[mattrjacobs]

@caarlos0 Thanks for the contribution - looks like a good change to me. One subtlety here is that the exception thrown is synchronous, while the method is returning an Observable<T>. I think that this is appropriate, as it distinguishes an actual error in the command data path (async onError) versus an error in the command setup.

I'll merge this and look at the flaky unit tests.

[caarlos0]

@mattrjacobs Nice to hear, thanks for the great lib, btw 🍻