Skip to content

Conversation

@nyango
Copy link
Contributor

@nyango nyango commented Mar 2, 2016

A link to Apache 2.0 license [![][license img]][license] in README.md links to
a dead link https://github.com/Netflix/Hystrix/blob/master/LICENSE-2.0.txt actually, which might not be intended.

A link to Apache 2.0 license `[![][license img]][license]` in README.md links to
a dead link https://github.com/Netflix/Hystrix/blob/master/LICENSE-2.0.txt actually, which might not be intended.
@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #370 FAILURE
Looks like there's a problem with this pull request

@spencergibb
Copy link
Contributor

https://github.com/Netflix/Hystrix/blob/master/LICENSE is a valid url, not sure why you're changing it.

@nyango
Copy link
Contributor Author

nyango commented Mar 3, 2016

When one views https://github.com/Netflix/Hystrix ,
one can see license links at the top of its README.md.
2016-03-03 11 28 07
A link "License Apache2" does not reach https://github.com/Netflix/Hystrix/blob/master/LICENSE but https://github.com/Netflix/Hystrix/blob/master/LICENSE-2.0.txt.
So, I have tried it.

@spencergibb
Copy link
Contributor

That link on the README is broken too.

image

@nyango
Copy link
Contributor Author

nyango commented Mar 3, 2016

Yes, THAT link is broken. This is why I tried to rename LICENSE → LICENSE-2.0.txt
Try it again at the branch https://github.com/nyango/Hystrix/tree/nyango-patch-1

@mattrjacobs
Copy link
Contributor

Thanks @nyango and @spencergibb !

mattrjacobs added a commit that referenced this pull request Mar 3, 2016
@mattrjacobs mattrjacobs merged commit 1dcd0fd into Netflix:master Mar 3, 2016
@nyango nyango deleted the nyango-patch-1 branch March 4, 2016 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants