iss993: added DefaultProperties annotation [ready for review]

[dmgcodevil]

fix for #993

[dmgcodevil]

PR in progress...

[mattrjacobs]

Is this ready for review?

[dmgcodevil]

Not yet, in progress. Will let you know when it's ready.
On 27 Jun 2016 9:18 a.m., "Matt Jacobs" [email protected] wrote:

Is this ready for review?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1259 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABWS8e2KLTAcGpfPdRVe0taecGM2jcsvks5qP820gaJpZM4I-vGS
.

[dmgcodevil]

@mattrjacobs it's ready for review. BTW is it possible to use java 8 ? I'm still using java 6 for javanica.

[spencergibb]

If I recall, 1.x is maintaining JVM 6. If not I'd ask to wait for 2.0 to change that.

[dmgcodevil]

It's ok. Will refactor it latter once 2.0 released. If PR is ok you can
merge it.
On 2 Jul 2016 9:37 p.m., "Spencer Gibb" [email protected] wrote:

If I recall, 1.x is maintaining JVM 6. If not I'd ask to wait for 2.0 to
change that.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1259 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABWS8cGf8C-z1wOTqnSB7Ca_VxOFurDvks5qRxJEgaJpZM4I-vGS
.

[mattrjacobs]

Yes, let's hold off on Java8 until 2.0

[mattrjacobs]

LGTM. Thanks @dmgcodevil ! I'll close #993. I'll get master in shape for a 1.5.4 release as well