Skip to content

Corrected ignoreExceptions for Observable returning methods. #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2016
Merged

Corrected ignoreExceptions for Observable returning methods. #1273

merged 1 commit into from
Jul 13, 2016

Conversation

@jbojar
Copy link

@jbojar jbojar commented Jul 8, 2016 •
edited
Loading

Corrected not working ignoreExceptions for Observables. Issue #1272

  • changed GenericObservableCommand to correctly wrap ignorable exceptions in HystrixBadRequestException using Observable.onErrorResumeNext,
  • changed HystrixCommandAspect to uwrap HystrixBadRequestException and HystrixRuntimeException conveyed by observble the same way as normally thrown exceptions are uwrapped,
  • added test for ignoring errors in observables similar to BasicErrorPropagationTest.

@jbojar
Corrected ignoreExceptions for Observable returning methods.
9a5d345 
- error handling for observables
- tests
@mattrjacobs
Copy link
Contributor

mattrjacobs commented Jul 13, 2016

Thanks for the contribution, @jbojar !

@mattrjacobs mattrjacobs merged commit e336976 into Netflix:master Jul 13, 2016
@smjdowling smjdowling mentioned this pull request Jul 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbojar @mattrjacobs