Javanica: basic Observable Collapser support #1320
Conversation
|
Thanks for the contribution @zsoltm ! Are you able to include any unit tests in this PR that demonstrate how to use the Observable-Collapsers in Javanica? |
| Class<?> collapserReturnType = collapserMethod.getReturnType(); | ||
| boolean observable = collapserReturnType.equals(Observable.class); | ||
|
|
||
| if (!batchReturnType.equals(List.class)) |
There was a problem hiding this comment.
I guess this check is redundant because
getDeclaredMethod(obj.getClass(), hystrixCollapser.batchMethod(), List.class) already checks return type, if batch method return type isn't List then getDeclaredMethod returns null.
There was a problem hiding this comment.
it's legacy code. anyway it's better to remove it
|
@zsoltm I've reviewed PR and left some comments. Also could you please update README with few examples that demonstrate new functionality. Thanks. |
|
@dmgcodevil thanks for the review, I made the changes in a hope that this is something useful. I just needed this in my project, hacked it together, and created a PR. I'm not 100% happy the way it ended up, so if you're working on a more elegant solution, feel free to drop this. |
|
@zsoltm PR looks good from my point of view. We should try to reuse existing abstractions rather than adding new once where it's possible. |
|
Thanks for the contribution @zsoltm ! Also, thanks @dmgcodevil for the design review |
3 participants
No description provided.