Skip to content

Conversation

bltb
Copy link
Contributor

@bltb bltb commented Oct 7, 2016

@mattrjacobs , what do you think?

@mattrjacobs
Copy link
Contributor

Yes, thank you!

@mattrjacobs mattrjacobs merged commit ad5e3f4 into Netflix:master Oct 7, 2016
@bltb
Copy link
Contributor Author

bltb commented Oct 7, 2016

By the way, in regards to thread keep alive time, in the code, I noticed that there are a couple of references to TimeUnit.MINUTES and in other places it is possible to pass the unit... do we need to or should we make these consistent?

Oh wait, I see... configuration only allows minutes... ignore my noise...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants