Single method which ensures core less than equal to maximum #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This centralizes the logic on how to determine the correct value to actually set the threadpool's max to. It now treats HystrixThreadPoolProperties#maximumSize() as the value configured (but possibly not used)
…roperties may be overridden
mattrjacobs
deleted the
single-method-which-ensures-core-less-than-equal-to-maximum
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1439 to distinguish the value configured as the maximum for the threadpool, and the value actually applied. In cases where the maximum was being pushed out, now both are.