Made circuit-opening happen in background #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduces new values * This allows for methods which imply reading the circuit-breaker status (isOpen/allowRequest) to be idempotent * Added new method (attemptExecution), which command internally uses to actually manipulate status
shakuzen
added a commit
to micrometer-metrics/micrometer
that referenced
this pull request
Nov 21, 2023
metrics are better with Netflix/Hystrix#1568 introduced in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
pirgeo
pushed a commit
to dynatrace-oss-contrib/micrometer
that referenced
this pull request
Dec 29, 2023
metrics are better with Netflix/Hystrix#1568 introduced in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
pirgeo
pushed a commit
to dynatrace-oss-contrib/micrometer
that referenced
this pull request
Jan 5, 2024
metrics are better with Netflix/Hystrix#1568 introduced in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as health counts stream produces new values
Addresses #1541