Skip to content
This repository was archived by the owner on Mar 4, 2021. It is now read-only.

Record the suffix-stripped version of termination events by the CloudFor...#140

Merged
ebukoski merged 4 commits into
Netflix:masterfrom
gnethercutt:cloudformation_asg_termination_naming
Jul 23, 2015
Merged

Record the suffix-stripped version of termination events by the CloudFor...#140
ebukoski merged 4 commits into
Netflix:masterfrom
gnethercutt:cloudformation_asg_termination_naming

Conversation

@gnethercutt
Copy link
Copy Markdown
Contributor

@gnethercutt gnethercutt commented Oct 13, 2014

...mationChaosMonkey to correctly respect maxTerminationsPerDay

@gnethercutt
Record the suffix-stripped version of termination events by the Cloud…
bc964a4 
…FormationChaosMonkey to correctly respect maxTerminationsPerDay
@cloudbees-pull-request-builder
Copy link
Copy Markdown

cloudbees-pull-request-builder commented Oct 13, 2014

SimianArmy-pull-requests #151 FAILURE
Looks like there's a problem with this pull request

@gnethercutt
Copy link
Copy Markdown
Contributor Author

gnethercutt commented Oct 13, 2014

The CloudFormationChaosMonkey overrides isMaxTerminationCountExceeded() to use the suffix-stripped version of the ASG name when evaluating targets in doMonkeyBusiness(). The termination events serialized into SDB do not have their groupName stripped of their CloudFormation suffix. This led to isMaxTerminationCountExceeded() always evaluating to false, and thus, multiple terminations for a single ASG each day.

The most straightforward (and consistent) fix seems to be overriding terminateInstance() as well.

@cloudbees-pull-request-builder
Copy link
Copy Markdown

cloudbees-pull-request-builder commented Oct 13, 2014

SimianArmy-pull-requests #152 FAILURE
Looks like there's a problem with this pull request

@gnethercutt
Conversion to the noSuffixInstance group name now happens in terminat…
dc201fb 
…eInstance, so remove it from sendTerminationNotification. Otherwise, we perform the conversion twice.
@cloudbees-pull-request-builder
Copy link
Copy Markdown

cloudbees-pull-request-builder commented Oct 13, 2014

SimianArmy-pull-requests #153 FAILURE
Looks like there's a problem with this pull request

@gnethercutt
Copy link
Copy Markdown
Contributor Author

gnethercutt commented Oct 13, 2014

Not sure why the cobertura report isn't getting generated. Looks like the target is being skipped, but I don't think that is related to my changes.

:generateCoberturaReport UP-TO-DATE

@cloudbees-pull-request-builder
Copy link
Copy Markdown

cloudbees-pull-request-builder commented Dec 14, 2014

SimianArmy-pull-requests #163 SUCCESS
This pull request looks good

ebukoski added a commit that referenced this pull request Jul 23, 2015
@ebukoski
Merge pull request #140 from gnethercutt/cloudformation_asg_terminati…
6e1c739 
…on_naming

Record the suffix-stripped version of termination events by the CloudFor...
@ebukoski ebukoski merged commit 6e1c739 into Netflix:master Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnethercutt @cloudbees-pull-request-builder @ebukoski