Skip to content
This repository was archived by the owner on Mar 4, 2021. It is now read-only.

Fix httpclient config #145

Merged
coryb merged 2 commits into from
Oct 28, 2014
Merged

Fix httpclient config #145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35a3b5b
Removes deprecated configuration classes for HttpClient library
Oct 28, 2014
5c04896
Changed httpclient and httpcode dependencies to 4.3+
Oct 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removes deprecated configuration classes for HttpClient library
  • Loading branch information
Marek Radonsky committed Oct 28, 2014
commit 35a3b5b2a45c8378c99fe7f41bdb8bd755bf9ccc
20 changes: 10 additions & 10 deletions src/main/java/com/netflix/simianarmy/client/MonkeyRestClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@
import org.apache.commons.lang.Validate;
import org.apache.http.HttpResponse;
import org.apache.http.client.HttpClient;
import org.apache.http.client.config.RequestConfig;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.impl.client.AutoRetryHttpClient;
import org.apache.http.impl.client.DefaultHttpClient;
import org.apache.http.impl.client.DefaultServiceUnavailableRetryStrategy;
import org.apache.http.params.BasicHttpParams;
import org.apache.http.params.HttpConnectionParams;
import org.apache.http.params.HttpParams;
import org.apache.http.impl.client.HttpClientBuilder;
import org.codehaus.jackson.JsonNode;
import org.codehaus.jackson.map.ObjectMapper;
import org.slf4j.Logger;
Expand Down Expand Up @@ -37,11 +34,14 @@ public MonkeyRestClient(int timeout, int maxRetries, int retryInterval) {
Validate.isTrue(timeout >= 0);
Validate.isTrue(maxRetries >= 0);
Validate.isTrue(retryInterval > 0);

HttpParams httpParams = new BasicHttpParams();
HttpConnectionParams.setConnectionTimeout(httpParams, timeout);
httpClient = new AutoRetryHttpClient(new DefaultHttpClient(httpParams),
new DefaultServiceUnavailableRetryStrategy(maxRetries, retryInterval));

RequestConfig config = RequestConfig.custom()
.setConnectTimeout(timeout)
.build();
httpClient = HttpClientBuilder.create()
.setDefaultRequestConfig(config)
.setServiceUnavailableRetryStrategy(new DefaultServiceUnavailableRetryStrategy(maxRetries, retryInterval))
.build();
}

/**
Expand Down