Skip to content

Conversation

madtibo
Copy link
Contributor

@madtibo madtibo commented Aug 16, 2018

add a jsonfield column of type jsonb to every table by default

Copy link
Collaborator

@musically-ut musically-ut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be useful!

This feature request is ready to be merged in. Just ping me about the not NULL constraints and I'll pull it in.

PostId int not NULL ,
RelatedPostId int not NULL ,
LinkTypeId int not Null
PostId int , -- not NULL ,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of the not-NULL constraint artifacts from the PR about the Foreign keys? Is it needed for adding JSON fields?

@madtibo
Copy link
Contributor Author

madtibo commented Aug 16, 2018

Yes, it was definitely an artefact!
It is now corrected.

@musically-ut
Copy link
Collaborator

I've tested this and merged it into the branch feat-postgresql-9.4. I don't think that PostgreSQL 9.3 (the last supported version) supports jsonb field-type but I haven't verified it.

In any case, as the EOL of 9.3 is this very month, I will merge it in as soon as 9.3 becomes unsupported.

Thanks!

@madtibo
Copy link
Contributor Author

madtibo commented Sep 3, 2018

You are right, jsonb is a 9.4 feature.
great that everything is functional :-)

@madtibo
Copy link
Contributor Author

madtibo commented Jan 21, 2019

@musically-ut 9.3 is now unsupported, could we merge this PR now?

@musically-ut musically-ut merged commit d5aa5c2 into Networks-Learning:master Jan 21, 2019
@musically-ut
Copy link
Collaborator

Thanks for the ping, merged! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants