ci: Move metrics comment from after_script to script #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
No significant changes. Insignifcant changes
|
daringer
approved these changes
Feb 17, 2025
Previously, we had the metrics comparison and comment creation in the after_script part of the metrics job so that a failure in these commands would not cause a CI failure. As we increasingly rely on the metrics comments and the relevant commands are pretty stable, this patch moves them to the script part so that we will notice failures more easily.
robin-nitrokey
force-pushed
the
metrics
branch
from
da73e88 to
0cb918f
Compare
robin-nitrokey
added a commit
that referenced
this pull request
Feb 20, 2025
In #594, we changed the metrics job to fail if the comment cannot be posted. This causes a CI failure on main as there is no matching PR for the CI run. This patch adds a condition to only post the comment if the CI runs against a branch other than main.
robin-nitrokey
added a commit
that referenced
this pull request
Feb 20, 2025
In #594, we changed the metrics job to fail if the comment cannot be posted. This causes a CI failure on main as there is no matching PR for the CI run. This patch adds a condition to only post the comment if the CI runs against a branch other than main.
robin-nitrokey
added a commit
that referenced
this pull request
Feb 20, 2025
In #594, we changed the metrics job to fail if the comment cannot be posted. This causes a CI failure on main as there is no matching PR for the CI run. This patch adds a condition to only post the comment if the CI runs against a branch other than main.
robin-nitrokey
added a commit
that referenced
this pull request
Mar 3, 2025
This temporarily reverts #594 as the current implementation does not work with merge commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had the metrics comparison and comment creation in the after_script part of the metrics job so that a failure in these commands would not cause a CI failure. As we increasingly rely on the metrics comments and the relevant commands are pretty stable, this patch moves them to the script part so that we will notice failures more easily.