Skip to content

nixos/nextcloud: set X-Robots-Tag to "noindex, nofollow" #223182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ma27 merged 1 commit into from
Mar 26, 2023
Merged

nixos/nextcloud: set X-Robots-Tag to "noindex, nofollow" #223182

Ma27 merged 1 commit into from
Mar 26, 2023

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 26, 2023

Description of changes

Upstream did so in nextcloud/server#36689 and Nextcloud now complains that

The "X-Robots-Tag" HTTP header is not set to "noindex, nofollow".
This is a potential security or privacy risk, as it is recommended
to adjust this setting accordingly.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda
nixos/nextcloud: set X-Robots-Tag to "noindex, nofollow"
15b859c 
Upstream did so in nextcloud/server#36689 and
Nextcloud now complains that

    The "X-Robots-Tag" HTTP header is not set to "noindex, nofollow".
    This is a potential security or privacy risk, as it is recommended
    to adjust this setting accordingly.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 26, 2023
@dotlambda
Copy link
Member Author

dotlambda commented Mar 26, 2023

@etu @Ma27 Should grocy do the same?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 26, 2023
RaitoBezarius
RaitoBezarius approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ma27
Copy link
Member

Ma27 commented Mar 26, 2023

@etu @Ma27 Should grocy do the same?

Sounds reasonable.

@Ma27 Ma27 merged commit 0680f29 into NixOS:master Mar 26, 2023
@github-actions github-actions bot mentioned this pull request Mar 26, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2023

Successfully created backport PR for release-22.11:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2023

Git push to origin failed for release-22.11 with exitcode 1

@dotlambda dotlambda deleted the nextcloud-x-robots-tag branch March 26, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@Ma27 Ma27 Ma27 approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @Ma27 @RaitoBezarius