-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
swift: force-unwrap file handles in swift-tools-support-core
#269015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
56aa31d
swiftpm: force-unwrap file handles in `swift-tools-support-core`
paveloom 647e9c8
swift-driver: force-unwrap file handles in `swift-tools-support-core`
paveloom d231730
sourcekit-lsp: force-unwrap file handles in `swift-tools-support-core`
paveloom 92e04e1
swift-format: force-unwrap file handles in `swift-tools-support-core`
paveloom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
pkgs/development/compilers/swift/sourcekit-lsp/patches/force-unwrap-file-handles.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| From 8d9ab4b6ed24a97e8af0cc338a52aacdcf438b8c Mon Sep 17 00:00:00 2001 | ||
| From: Pavel Sobolev <[email protected]> | ||
| Date: Tue, 21 Nov 2023 20:53:33 +0300 | ||
| Subject: [PATCH] Force-unwrap file handles. | ||
|
|
||
| --- | ||
| Sources/TSCBasic/FileSystem.swift | 4 ++-- | ||
| 1 file changed, 2 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/Sources/TSCBasic/FileSystem.swift b/Sources/TSCBasic/FileSystem.swift | ||
| index 3a63bdf..a1f3d9d 100644 | ||
| --- a/Sources/TSCBasic/FileSystem.swift | ||
| +++ b/Sources/TSCBasic/FileSystem.swift | ||
| @@ -425,7 +425,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Read the data one block at a time. | ||
| let data = BufferedOutputByteStream() | ||
| @@ -455,7 +455,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Write the data in one chunk. | ||
| var contents = bytes.contents | ||
| -- | ||
| 2.42.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
pkgs/development/compilers/swift/swift-driver/patches/force-unwrap-file-handles.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| From 8d9ab4b6ed24a97e8af0cc338a52aacdcf438b8c Mon Sep 17 00:00:00 2001 | ||
| From: Pavel Sobolev <[email protected]> | ||
| Date: Tue, 21 Nov 2023 20:53:33 +0300 | ||
| Subject: [PATCH] Force-unwrap file handles. | ||
|
|
||
| --- | ||
| Sources/TSCBasic/FileSystem.swift | 4 ++-- | ||
| 1 file changed, 2 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/Sources/TSCBasic/FileSystem.swift b/Sources/TSCBasic/FileSystem.swift | ||
| index 3a63bdf..a1f3d9d 100644 | ||
| --- a/Sources/TSCBasic/FileSystem.swift | ||
| +++ b/Sources/TSCBasic/FileSystem.swift | ||
| @@ -425,7 +425,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Read the data one block at a time. | ||
| let data = BufferedOutputByteStream() | ||
| @@ -455,7 +455,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Write the data in one chunk. | ||
| var contents = bytes.contents | ||
| -- | ||
| 2.42.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
pkgs/development/compilers/swift/swift-format/patches/force-unwrap-file-handles.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| From 8d9ab4b6ed24a97e8af0cc338a52aacdcf438b8c Mon Sep 17 00:00:00 2001 | ||
| From: Pavel Sobolev <[email protected]> | ||
| Date: Tue, 21 Nov 2023 20:53:33 +0300 | ||
| Subject: [PATCH] Force-unwrap file handles. | ||
|
|
||
| --- | ||
| Sources/TSCBasic/FileSystem.swift | 4 ++-- | ||
| 1 file changed, 2 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/Sources/TSCBasic/FileSystem.swift b/Sources/TSCBasic/FileSystem.swift | ||
| index 3a63bdf..a1f3d9d 100644 | ||
| --- a/Sources/TSCBasic/FileSystem.swift | ||
| +++ b/Sources/TSCBasic/FileSystem.swift | ||
| @@ -425,7 +425,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Read the data one block at a time. | ||
| let data = BufferedOutputByteStream() | ||
| @@ -455,7 +455,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Write the data in one chunk. | ||
| var contents = bytes.contents | ||
| -- | ||
| 2.42.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
pkgs/development/compilers/swift/swiftpm/patches/force-unwrap-file-handles.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| From 8d9ab4b6ed24a97e8af0cc338a52aacdcf438b8c Mon Sep 17 00:00:00 2001 | ||
| From: Pavel Sobolev <[email protected]> | ||
| Date: Tue, 21 Nov 2023 20:53:33 +0300 | ||
| Subject: [PATCH] Force-unwrap file handles. | ||
|
|
||
| --- | ||
| Sources/TSCBasic/FileSystem.swift | 4 ++-- | ||
| 1 file changed, 2 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/Sources/TSCBasic/FileSystem.swift b/Sources/TSCBasic/FileSystem.swift | ||
| index 3a63bdf..a1f3d9d 100644 | ||
| --- a/Sources/TSCBasic/FileSystem.swift | ||
| +++ b/Sources/TSCBasic/FileSystem.swift | ||
| @@ -425,7 +425,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Read the data one block at a time. | ||
| let data = BufferedOutputByteStream() | ||
| @@ -455,7 +455,7 @@ private class LocalFileSystem: FileSystem { | ||
| if fp == nil { | ||
| throw FileSystemError(errno: errno, path) | ||
| } | ||
| - defer { fclose(fp) } | ||
| + defer { fclose(fp!) } | ||
|
|
||
| // Write the data in one chunk. | ||
| var contents = bytes.contents | ||
| -- | ||
| 2.42.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.