Skip to content

Conversation

@donn
Copy link
Member

@donn donn commented Jan 15, 2024

Description of changes

This backports #269015 to release-23.11, as without these patches, the Swift programming language is broken on 23.11

Affected derivations are:

  • swiftpm
  • sourcekit-lsp
  • swift-format
  • swift-driver

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

paveloom and others added 3 commits January 15, 2024 16:24
fixes building swiftpm

(cherry picked from commit 56aa31d)
fixes building swift-driver

(cherry picked from commit 647e9c8)
fixes building sourcekit-lsp

(cherry picked from commit d231730)
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jan 15, 2024
@donn donn marked this pull request as ready for review January 15, 2024 16:30
@donn donn changed the title backport swift: force-unwrap file handles in swift-tools-support-core backport swift: force-unwrap file handles in swift-tools-support-core to 23.11 Jan 15, 2024
fixes building swift-format

(cherry picked from commit 92e04e1)
@donn donn changed the title backport swift: force-unwrap file handles in swift-tools-support-core to 23.11 [Backport release-23.11] swift: force-unwrap file handles in swift-tools-support-core Jan 15, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 16, 2024
@finagolfin
Copy link

Do you mind trying my upstream pull instead? swiftlang/swift-tools-support-core#457

@donn
Copy link
Member Author

donn commented May 6, 2024

I didn't author this PR, I'm merely backporting it.

That said, may not be a bad idea to create a PR with your patch for master

@donn
Copy link
Member Author

donn commented May 19, 2024

I suppose there's no point keeping this open for much longer given 24.05 is on the horizon.

@donn donn closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants