Skip to content

Conversation

@andir
Copy link
Member

@andir andir commented Nov 25, 2017

Motivation for this change

The RTMP module requires a few /* fall through */ comments with gcc-7
which are included in the introduced patch. The used patch was proposed
to the upstream repo [1] quite a while ago so it probably is best to
include it for now.

[1] arut/nginx-rtmp-module#1125

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 25, 2017
adds support for gcc-7 and fixes nginx for NixOS#31747
@andir andir mentioned this pull request Dec 4, 2017
@andir
Copy link
Member Author

andir commented Dec 7, 2017

CC maintainers @thoughtpolice @raskin @fpletz

@joachifm joachifm merged commit 8a11e0d into NixOS:master Dec 14, 2017
@andir andir deleted the nginx-rtmp-gcc7 branch December 14, 2017 22:55
@campones
Copy link

campones commented Nov 2, 2020

hello

just installed ubuntu 20.04 that apparently comes with gcc9 and I m stuck with the same issue.

/root/nginx-rtmp-module-master/ngx_rtmp_eval.c:160:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
160 | switch (c) {
| ^~~~~~
/root/nginx-rtmp-module-master/ngx_rtmp_eval.c:170:13: note: here
170 | case ESCAPE:
| ^~~~
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:1479: objs/addon/nginx-rtmp-module-master/ngx_rtmp_eval.o] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants