Skip to content

nextcloud-talk-desktop: add darwin support #442932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Nov 26, 2025
Merged

nextcloud-talk-desktop: add darwin support #442932

SuperSandro2000 merged 1 commit into from
Nov 26, 2025

Conversation

@kashw2
Copy link
Contributor

@kashw2 kashw2 commented Sep 14, 2025 •
edited
Loading

Added darwin support for Nextcloud Talk (Desktop)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 14, 2025
@kashw2
Copy link
Contributor Author

kashw2 commented Sep 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442932
Commit: 1eb952591ccec149881569ddb665da3252f4d701

aarch64-linux

✅ 1 package built:
  • nextcloud-talk-desktop

x86_64-darwin

✅ 1 package built:
  • nextcloud-talk-desktop

aarch64-darwin

✅ 1 package built:
  • nextcloud-talk-desktop

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 14, 2025
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 6.topic: darwin Running or building packages on Darwin labels Sep 14, 2025
dotlambda
dotlambda reviewed Sep 14, 2025
View reviewed changes
@kashw2 kashw2 force-pushed the nextcloud-talk-desktop-darwin-support branch from 1eb9525 to 7e61751 Compare September 14, 2025 16:22
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 14, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 14, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 14, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 9, 2025
@kashw2 kashw2 force-pushed the nextcloud-talk-desktop-darwin-support branch 2 times, most recently from 6624099 to 15ed374 Compare October 22, 2025 03:14
@nixpkgs-ci nixpkgs-ci bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 22, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 7, 2025
@kashw2 kashw2 force-pushed the nextcloud-talk-desktop-darwin-support branch from 15ed374 to c292787 Compare November 10, 2025 22:15
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2025
SuperSandro2000
SuperSandro2000 reviewed Nov 21, 2025
View reviewed changes
@kashw2 kashw2 force-pushed the nextcloud-talk-desktop-darwin-support branch from 8b7d625 to 906839c Compare November 25, 2025 09:12
@kashw2 kashw2 force-pushed the nextcloud-talk-desktop-darwin-support branch from 906839c to b031816 Compare November 25, 2025 09:14
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 26, 2025
Merged via the queue into NixOS:master with commit 84574e5 Nov 26, 2025
28 of 30 checks passed
@kashw2 kashw2 deleted the nextcloud-talk-desktop-darwin-support branch November 26, 2025 13:19
This was referenced Dec 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

+1 more reviewer

@provokateurin provokateurin provokateurin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kashw2 @dotlambda @SuperSandro2000 @provokateurin