-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
librepods: init at 0.2.0-alpha #444137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
librepods: init at 0.2.0-alpha #444137
Conversation
7a6fb09 to
94a8d63
Compare
|
|
94a8d63 to
044a791
Compare
044a791 to
3a3275b
Compare
acid-bong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now i'm back at my pc and can test what i'm suggesting. all these are tested locally and work on my machine™️
3a3275b to
7d7fa4f
Compare
acid-bong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little nitpick, and i'm done 😅
|
No problem, I really appreciate your patience. There is just one thing from my side. The nightly version showed some logs about Is there a way we can set this in the package or is this something the user has to do? |
7d7fa4f to
0e76adc
Compare
|
You can write a nixos module to set security.wrappers |
0e76adc to
581227e
Compare
|
I now wrote a module and patched the autostart .desktop file because with the original path it failed to load But it might be better to fix this upstream and to obtain the right path. https://github.com/kavishdevar/librepods/blob/main/linux/autostartmanager.hpp#L58 |
581227e to
842d85e
Compare
842d85e to
d56a42d
Compare
|
|
Works well for me (with the wrapper), except for theming: |
|
Is there anything I can do to speed this up and get this merged? I would love to just try it out without messing around with a bunch of nix build files |
If you know how to solve this problem with the autostart path. I mean it doesn't cause any severe issues but I want it to be as it is intended by it's creators. |
|
What is the intended use of the autostart path? It seems to work fine as it is right now. And could you please address the requested changes to the module and the package? These requested changes are also preventing the PR from being merged. |
d56a42d to
3eafb6b
Compare
58b2b2a to
e909d34
Compare
|
There is a new iced implementation kavishdevar/librepods#241, and the old qt one seems to have halted development. Quoting https://github.com/kavishdevar/librepods#linux
Non-blocking: I think its fine to package the current one still, but better not backport it to stable. |
|
Thanks for the hint |
e909d34 to
0f11426
Compare
I do have the iced version packaged in my nixos-config, I was just waiting for it to be on the main branch before finalizing it. You can totally copy from it if you package it here at some point. :) |
That’s good to know, especially for the Iced stuff. |
0f11426 to
1c229bf
Compare
Add librepods:
AirPods libreated from Apple's ecosystem.https://github.com/kavishdevar/librepods
There is just one problem when running it.
Running librepods as root is a workaround for this but
pactlThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.